-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11878] Merge master into feature #13011
[#11878] Merge master into feature #13011
Commits on Mar 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9a099c1 - Browse repository at this point
Copy the full SHA 9a099c1View commit details
Commits on Mar 24, 2024
-
[TEAMMATES#12048] Add SQL configuration into build.properties and bui…
…ld-dev.properties (TEAMMATES#12917) * Add production config * Remove forgotten host and password * Fix lint --------- Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e0c6a2d - Browse repository at this point
Copy the full SHA e0c6a2dView commit details -
[TEAMMATES#12048] Add SQL description for postgres config (TEAMMATES#…
…12931) * Add production config * Remove forgotten host and password * Fix lint * Address changes, include production_user * Linting
Configuration menu - View commit details
-
Copy full SHA for 845009e - Browse repository at this point
Copy the full SHA 845009eView commit details
Commits on Mar 25, 2024
-
[TEAMMATES#12588] Improve test code coverage of core components - Toa…
…stComponent (TEAMMATES#12916) * add test cases * add test case for isTemplate() --------- Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com> Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3499d2a - Browse repository at this point
Copy the full SHA 3499d2aView commit details -
[TEAMMATES#12588] Add unit tests to question edit answer form (TEAMMA…
…TES#12935) * add unit tests to constsum-options-question-edit-answer-form * add unit tests to constsum-options-question-edit-answer-form --------- Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7ba20fc - Browse repository at this point
Copy the full SHA 7ba20fcView commit details -
add delay to task queuer for indexing account request (TEAMMATES#12936)
Co-authored-by: Nicolas <25302138+NicolasCwy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1be2adb - Browse repository at this point
Copy the full SHA 1be2adbView commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 716fdc4 - Browse repository at this point
Copy the full SHA 716fdc4View commit details -
[TEAMMATES#12048] Relax read notif verification for migration verific…
…ation script (TEAMMATES#12937) * Fix account requests with wrong field during seed * Relax account attributes verification * Fix lint errors * Fix order of account request variables
Configuration menu - View commit details
-
Copy full SHA for ca20709 - Browse repository at this point
Copy the full SHA ca20709View commit details -
[TEAMMATES#12920] Create script to migrate noSQL test data to SQL sch…
…ema format (TEAMMATES#12922) * Add classes to migrate test json data * Add toposort script * Add function to remove foreign key data * Cleanup * WIP * Simplify keys for students and instructors * Fix lint issues * Output SQL JSON in same folder as JSON * Change output file name * Fix bug: wrong jsonkey used * Fix lint error * Make section and team name unique * Set read notification key to be unique * Delete python file
Configuration menu - View commit details
-
Copy full SHA for e435f17 - Browse repository at this point
Copy the full SHA e435f17View commit details -
[TEAMMATES#12588] Improve test code coverage of core components - Vie…
…wResultsPanelComponent (TEAMMATES#12918) * add test cases to ViewResultsPanelComponent * fix lint errors --------- Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com> Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a02f444 - Browse repository at this point
Copy the full SHA a02f444View commit details -
fix resetAccountAction (TEAMMATES#12934)
Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 11b8b81 - Browse repository at this point
Copy the full SHA 11b8b81View commit details -
[TEAMMATES#12048] Migrate Feedback Rank Option E2E test (TEAMMATES#12902
) * Initial commit * Fix lint * Follow convention and add test * Change file path * Fix requested changes * Fixed testcases * Fix lint * Add deepcopy * Fixed e2e test --------- Co-authored-by: Wei Qing <48304907+weiquu@users.noreply.github.com> Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0cfadef - Browse repository at this point
Copy the full SHA 0cfadefView commit details -
[TEAMMATES#12048] Migrate FeedbackMcqQuestionE2ETest (TEAMMATES#12820)
* Migrate MCQ E2E * Fix lint * Fix lint * Update xml --------- Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e51132e - Browse repository at this point
Copy the full SHA e51132eView commit details
Commits on Mar 27, 2024
-
[TEAMMATES#12048] Remove unnecessary loading of datastore entities in…
… InstructorNotificationsPageE2ETest (TEAMMATES#12911) * migrate instructor notif e2e --------- Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 20df6b6 - Browse repository at this point
Copy the full SHA 20df6b6View commit details -
[TEAMMATES#12048] Migrate InstructorCourseDetailsPageE2ETest (TEAMMAT…
…ES#12908) * Add teammates.e2e.cases.sql.InstructorCourseDetailsPageE2ETest * Remove data properly to prevent clashes * Add SQL data bundle * Verify loaded details * Use email address when getting a student row * Check student links * Verify the sending of invites * Verify the reminding of all students to join * Remove SQL data properly to prevent clashes * Verify the downloading of the student list * Implement helper methods for Student * Add BaseTestCaseWithSqlDatabaseAccess::verifyAbsentInDatabase * Add to testng-e2e-sql.xml * Verify the deleting of students * Verify the deleting of all the students * Fix lint * Remove duplicate equality check for students
Configuration menu - View commit details
-
Copy full SHA for a9423da - Browse repository at this point
Copy the full SHA a9423daView commit details
Commits on Mar 28, 2024
-
[TEAMMATES#12588] add unit tests for question submission form (TEAMMA…
…TES#12897) Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 78eee47 - Browse repository at this point
Copy the full SHA 78eee47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d0cf37 - Browse repository at this point
Copy the full SHA 9d0cf37View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4fe140 - Browse repository at this point
Copy the full SHA c4fe140View commit details
Commits on Mar 29, 2024
-
[TEAMMATES#12048] Fix account request indexing (TEAMMATES#12967)
* Add isTransactionNeeded method to Action * Remove delay from taskqueuer * Change CreateAccountRequest to handle own transactions
Configuration menu - View commit details
-
Copy full SHA for 356c318 - Browse repository at this point
Copy the full SHA 356c318View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ee4269 - Browse repository at this point
Copy the full SHA 2ee4269View commit details
Commits on Apr 3, 2024
-
[TEAMMATES#12048] Configure connection pool using hikari (TEAMMATES#1…
…2978) * Configure hikari * Remove spacing * Lint
Configuration menu - View commit details
-
Copy full SHA for 38dbf29 - Browse repository at this point
Copy the full SHA 38dbf29View commit details
Commits on Apr 6, 2024
-
[TEAMMATES#12048] Update liquibase configuration (TEAMMATES#12930)
* Update gradle config * Update liquibase config for v9 * Turn off table generate for prod * Update of changelog file * Add configuration for generating changelog * Add schema migration docs --------- Co-authored-by: FergusMok <FergusMok1@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 028c953 - Browse repository at this point
Copy the full SHA 028c953View commit details
Commits on Apr 8, 2024
-
[TEAMMATES#12048] Migrate AccountRequestsLogicTest (TEAMMATES#12780)
* Migrate test cases for AccountRequestsLogic * Remove test case * Split test cases
Configuration menu - View commit details
-
Copy full SHA for 1e9ccb0 - Browse repository at this point
Copy the full SHA 1e9ccb0View commit details -
[TEAMMATES#12048] Migrate AdminSearchPageE2ETest SQL (TEAMMATES#12811)
* test e2e changes * fix: reduce e2e test json file size * fix student key * fix course key * fix instructor keys * fix filepath * fix e2e test * remove extra data from bundle * Add correct removal logic to avoid constraint violation * Fix e2e tests and lint fix reset google id test fix e2e tests fix e2e tests fix tests remove double click fix unknown symbol add toast check change toast verification message remove toast check * fix: add null check * move admin search page e2e test to sql cases * Rename AdminSearchPageE2ETest_SQLEntities.json to AdminSearchPageE2ETest_SqlEntities.json * fix failing test * fix: remove extra null check * fix: add test to e2e sql xml file * fix function call * remove unnecessary changes * create new file for sql entities * revert unnecessary changes * remove trailing whitespace * add teardown for account requests --------- Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 84ed244 - Browse repository at this point
Copy the full SHA 84ed244View commit details -
[TEAMMATES#12995] Create documentation for unit tests (TEAMMATES#12996)
* Create documentation for unit tests * Update docs/unit-testing.md Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com> * Update docs/unit-testing.md Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com> --------- Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for db0fd94 - Browse repository at this point
Copy the full SHA db0fd94View commit details
Commits on Apr 9, 2024
-
[TEAMMATES#12048] Remove feedbackSession attributes @fetch annotation (…
…TEAMMATES#12992) * Remove feedbackSession @fetch annotation
Configuration menu - View commit details
-
Copy full SHA for 6c420fa - Browse repository at this point
Copy the full SHA 6c420faView commit details -
[TEAMMATES#12048] create skeleton for sql LNP tests (TEAMMATES#12994)
* create skelton for sql LNP tests * allow lnp test to access sql storage and ensure sql lnp tests are independant of each other --------- Co-authored-by: Zhang Ziqing <69516975+ziqing26@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8f43cc8 - Browse repository at this point
Copy the full SHA 8f43cc8View commit details -
[TEAMMATES#12048] Migrate FeedbackNumScaleQuestionE2ETest (TEAMMATES#…
…12940) * Migrate num scale e2e * Fix team id * Fix bugs
Configuration menu - View commit details
-
Copy full SHA for b9ccd4f - Browse repository at this point
Copy the full SHA b9ccd4fView commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2354975 - Browse repository at this point
Copy the full SHA 2354975View commit details -
sort courses by id before comparison (TEAMMATES#13003)
Co-authored-by: Dominic Lim <46486515+domlimm@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for fb7c4e8 - Browse repository at this point
Copy the full SHA fb7c4e8View commit details
Commits on Apr 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4595cf3 - Browse repository at this point
Copy the full SHA 4595cf3View commit details