Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11843] Fix front end bugs #13037

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

dishenggg
Copy link
Contributor

@dishenggg dishenggg commented Apr 15, 2024

Part of #11843

Outline of Solution

  • Fix not viewed since message
  • Updated disclaimer message
    image

@dishenggg dishenggg marked this pull request as ready for review April 15, 2024 13:39
@dishenggg dishenggg self-assigned this Apr 15, 2024
@dishenggg dishenggg added the s.ToReview The PR is waiting for review(s) label Apr 15, 2024
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cedricongjh cedricongjh added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Apr 16, 2024
@FergusMok
Copy link
Contributor

FergusMok commented Apr 16, 2024

@dishenggg @cedricongjh I realized there's also this edge case that might be misleading (probably not as common)

  1. Person submitted the responses on 12th April
  2. Query logs from 1st April to 11th April
    The message will be "Not submitted responses since Mon, 01 Apr 2024 ... "

I'd rather we display something true, i.e "No access / submitted responses in the query range", or some alternatives that I can think of:

  1. Have another action to query the latest logs for each student and display to show either "no submission / access", or the latest submission / access. But I also understand that it's quite close to the release and the action might take a significant amount of work, or
  2. Make the end query time to current time permanently, and the current statement will always be true, or
  3. Change the message to "No access / submitted responses in the query range".

What do you guys think

@dishenggg
Copy link
Contributor Author

dishenggg commented Apr 16, 2024

  1. Change the message to "No access / submitted responses in the query range".

I think this would be the better option for now, since there might be uses for the instructors to query up to a certain date/time e.g., a deadline

@FergusMok FergusMok added s.Ongoing The PR is being worked on by the author(s) and removed s.FinalReview The PR is ready for final review labels Apr 17, 2024
@dishenggg dishenggg added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Apr 17, 2024
Copy link
Contributor

@FergusMok FergusMok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for working on these fixes! 👍

@FergusMok FergusMok merged commit 9a51e2a into TEAMMATES:student-activity-logs Apr 18, 2024
1 check passed
@ziqing26 ziqing26 added this to the V9.0.0-beta.5 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants