-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11843] Fix front end bugs #13037
[#11843] Fix front end bugs #13037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@dishenggg @cedricongjh I realized there's also this edge case that might be misleading (probably not as common)
I'd rather we display something true, i.e "No access / submitted responses in the query range", or some alternatives that I can think of:
What do you guys think |
I think this would be the better option for now, since there might be uses for the instructors to query up to a certain date/time e.g., a deadline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for working on these fixes! 👍
Part of #11843
Outline of Solution