-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12679] & [#12653] Copying feedback session: Name for copied session should not be whitespace & Copy course modal: Mandatory fields not highlighted #13075
Conversation
Hi @Josephine0110, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
@Josephine0110 Do fix the failing tests. You can find out more about how to update tests in our documentation |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Hi @Josephine0110 could you please fix the failing component tests? Do let us know if you need any help |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢 |
Hi @Josephine0110, I've noticed there hasn't been any activity on this PR for awhile. Are you still working on this? If you need any help or have decided not to continue, please let us know so someone else may pick up this issue to keep things moving. Thank you for your contribution! |
@Josephine0110 closing due to inactivity, please reopen when ready! |
Fixes #12679
Fixes #12653
Outline of Solution
For Issue#12679
Added a validator to copy session component, checking whether the feedback session name is whitespace or not. If the Name for feedback session is only composed of whitespace, the red warning of "The field "Name for copied session" should not be empty." would appear on the screen.
Before: (from the issues)
After:
For Issue#12653
Modified frontend to make the user input of Course ID and Course Name mandatory by adding a red warning sign down the input box
Before:
After: