Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12679] & [#12653] Copying feedback session: Name for copied session should not be whitespace & Copy course modal: Mandatory fields not highlighted #13075

Closed
wants to merge 7 commits into from

Conversation

Josephine0110
Copy link

@Josephine0110 Josephine0110 commented Apr 21, 2024

Fixes #12679
Fixes #12653

Outline of Solution

For Issue#12679
Added a validator to copy session component, checking whether the feedback session name is whitespace or not. If the Name for feedback session is only composed of whitespace, the red warning of "The field "Name for copied session" should not be empty." would appear on the screen.

Before: (from the issues)
image

After:
Screenshot 2024-04-21 at 2 43 56 PM

For Issue#12653
Modified frontend to make the user input of Course ID and Course Name mandatory by adding a red warning sign down the input box

Before:
image

After:
image

Copy link

Hi @Josephine0110, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@Josephine0110 Josephine0110 changed the title [#12679]Copying feedback session: Name for copied session should not be whitespace [#12679] & [#12653] Copying feedback session: Name for copied session should not be whitespace Apr 21, 2024
@Josephine0110 Josephine0110 changed the title [#12679] & [#12653] Copying feedback session: Name for copied session should not be whitespace [#12679] & [#12653] Copying feedback session: Name for copied session should not be whitespace & Apr 21, 2024
@Josephine0110 Josephine0110 changed the title [#12679] & [#12653] Copying feedback session: Name for copied session should not be whitespace & [#12679] & [#12653] Copying feedback session: Name for copied session should not be whitespace & Copy course modal: Mandatory fields not highlighted Apr 21, 2024
@weiquu
Copy link
Contributor

weiquu commented Jun 29, 2024

@Josephine0110 Do fix the failing tests. You can find out more about how to update tests in our documentation

@weiquu weiquu added the s.Ongoing The PR is being worked on by the author(s) label Jun 29, 2024
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@domoberzin
Copy link
Contributor

Hi @Josephine0110 could you please fix the failing component tests? Do let us know if you need any help

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢
Hope someone can get it to move forward again soon...

@domoberzin
Copy link
Contributor

Hi @Josephine0110,

I've noticed there hasn't been any activity on this PR for awhile. Are you still working on this? If you need any help or have decided not to continue, please let us know so someone else may pick up this issue to keep things moving.

Thank you for your contribution!

@mingyuanc
Copy link
Contributor

@Josephine0110 closing due to inactivity, please reopen when ready!

@mingyuanc mingyuanc closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
5 participants