[#12048] Add patch script for account request and notifications to amend createdAt field #13077
Conversation
NicolasCwy
added
s.ToReview
| // Get first items since there is guaranteed to be one | ||
| teammates.storage.sqlentity.AccountRequest newAccountReq = matchingAccounts.get(0); | ||
| newAccountReq.setCreatedAt(oldEntity.getCreatedAt()); | ||
| HibernateUtil.commitTransaction(); |
There was a problem hiding this comment.
Since we're fetching an existing entity, changing the object attribute will save the changes in the DB
ziqing26
added
s.FinalReview
| if (matchingAccounts.size() > 1) { | ||
| throw new Error("More than one matching account request found"); | ||
| } else if (matchingAccounts.size() == 0){ | ||
| throw new Error("No matching account found"); | ||
| } | ||
|
|
||
| // Get first items since there is guaranteed to be one | ||
| teammates.storage.sqlentity.AccountRequest newAccountReq = matchingAccounts.get(0); |
There was a problem hiding this comment.
What if the account request has already been processed / deleted in SQL? I didn't look into how accounts are created, but does it delete the request?
There was a problem hiding this comment.
Seems like processing the account (approving / rejecting) does not delete the SQL entity. But its possible that prof manually deletes them let me check in with him
| * Returns the filter query. | ||
| */ | ||
| protected Query<teammates.storage.entity.AccountRequest> getFilterQuery() { | ||
| return ofy().load().type(teammates.storage.entity.AccountRequest.class); |
There was a problem hiding this comment.
Not important, only if you have time.
https://cloud.google.com/datastore/docs/concepts/queries#projection_queries
Not sure if we can do a projection query to speed up, since we're only interested in institute, email, name and createdAt. Objectify has a project()
Part of #12048
Context
Previously during the non-course migration,
createdAtwas not migrated due to having the@createdTimestampannotation. This was removed in the v9-course-migration branch and can be used for this as well.Outline of Solution
Add 2 scripts based of
PatchDataMigrationForUsageStatisticsSqlto fetch existing account requests and notifications using fields which are identifiers for the entity and amend theircreatedAttimestamp. Most of the changes are inMigrateEntitymethod. Verification Scripts can handle the case where an entity exist in postgres but not in datastore (since we have started created new account requests and notification in postgres)Fields which are identifiers