Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11878] Add CAPTCHA to ARF #13081

Merged
merged 5 commits into from
Apr 23, 2024
Merged

[#11878] Add CAPTCHA to ARF #13081

merged 5 commits into from
Apr 23, 2024

Conversation

xenosf
Copy link
Contributor

@xenosf xenosf commented Apr 22, 2024 •
edited
Loading

Part of #11878

Outline of Solution

  • Add CAPTCHA to create account request form

@xenosf xenosf added the s.Ongoing The PR is being worked on by the author(s) label Apr 22, 2024
@xenosf xenosf self-assigned this Apr 22, 2024
@xenosf xenosf changed the title [#13080] Add captcha to ARF [#13080] Add CAPTCHA to ARF Apr 22, 2024
@xenosf xenosf changed the title [#13080] Add CAPTCHA to ARF [#11878] Add CAPTCHA to ARF Apr 22, 2024
@xenosf xenosf added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Apr 22, 2024
@ziqing26 ziqing26 added p.Urgent Would like to handle in the very next release c.Feature User-facing feature; can be new feature or enhancement to existing feature labels Apr 23, 2024
@ziqing26 ziqing26 added this to the V9.0.0-beta.6 milestone Apr 23, 2024
jayasting98
jayasting98 requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@jayasting98 jayasting98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small but significant change may be necessary.

src/main/java/teammates/ui/request/AccountCreateRequest.java Outdated Show resolved Hide resolved
@xenosf xenosf requested a review from jayasting98 April 23, 2024 04:56
@ziqing26 ziqing26 self-requested a review April 23, 2024 05:36
ziqing26
ziqing26 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@ziqing26 ziqing26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix.

@ziqing26 ziqing26 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Apr 23, 2024
jayasting98
jayasting98 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@jayasting98 jayasting98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks!

@jayasting98 jayasting98 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Apr 23, 2024
@jayasting98 jayasting98 merged commit 6b83e4f into TEAMMATES:master Apr 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayasting98 jayasting98 jayasting98 approved these changes

@ziqing26 ziqing26 ziqing26 approved these changes

@EuniceSim142 EuniceSim142 Awaiting requested review from EuniceSim142

Assignees

@xenosf xenosf

Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature p.Urgent Would like to handle in the very next release s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.6
Development

Successfully merging this pull request may close these issues.
3 participants
@xenosf @jayasting98 @ziqing26