Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Fix seed, migration and verification script for course verification #13086

Merged
merged 23 commits into from
Apr 24, 2024
Merged

[#12048] Fix seed, migration and verification script for course verification #13086

merged 23 commits into from
Apr 24, 2024

Conversation

NicolasCwy
Copy link
Contributor

@NicolasCwy NicolasCwy commented Apr 23, 2024 •
edited
Loading

Part of #12048

Outline of Solution

  • Modify seed DB script to map student to a valid account
  • Fix migration script to
    • use google id instead of email to map accounts
    • allocate deadline extensions for students and instructors separately
  • Add logging to verification script

TODO

  • section chain - account and google id mismatch

YX Z and others added 15 commits April 6, 2024 10:24
Add migration and verification script for feedback session
3e108c7
Optimize data migration
2275560
Fix lint
dba2272
Uncomment seed feedback session function
64e02d8
Add counts verification script
280eaed
Merge branch 'v9-course-migration' of https://github.com/TEAMMATES/te…
8d8e054 
…ammates into v9-course-migration
Merge branch 'v9-course-migration' of https://github.com/TEAMMATES/te…
fd92583 
…ammates into v9-course-migration
Merge branch 'v9-course-migration' of https://github.com/TEAMMATES/te…
04f49c6 
…ammates into v9-course-migration
Merge branch 'v9-course-migration' of https://github.com/TEAMMATES/te…
27502b9 
…ammates into v9-course-migration
Merge branch 'v9-course-migration' of https://github.com/TEAMMATES/te…
72098b3 
…ammates into v9-course-migration
Fix some small issues
89293f4
@NicolasCwy
Abstract seed account method
46f669c
@NicolasCwy
Combine non-course and course seed methods
cc493e8
@NicolasCwy
Fix migration script
0b38691
@NicolasCwy
Add additional logs
80bcac0
@NicolasCwy NicolasCwy changed the base branch from master to v9-course-migration April 23, 2024 19:11
@NicolasCwy NicolasCwy changed the title [#12048] Fix seed, migration and verification script [#12048] Fix seed, migration and verification script for non-course verification Apr 23, 2024
@NicolasCwy NicolasCwy changed the title [#12048] Fix seed, migration and verification script for non-course verification [#12048] Fix seed, migration and verification script for course verification Apr 23, 2024
@NicolasCwy NicolasCwy marked this pull request as ready for review April 24, 2024 04:14
@NicolasCwy NicolasCwy self-assigned this Apr 24, 2024
@FergusMok FergusMok force-pushed the fix-seed-account-student-email branch from 6bc93fb to 80bcac0 Compare April 24, 2024 05:42
@NicolasCwy @marquestye
Update DataMigrationForCourseEntitySql.java
64285e9 
Co-authored-by: Marques Tye Jia Jun <97437396+marquestye@users.noreply.github.com>
@marquestye
Copy link
Contributor

LGTM!

@NicolasCwy NicolasCwy merged commit 4c4a900 into TEAMMATES:v9-course-migration Apr 24, 2024
1 check passed
@NicolasCwy NicolasCwy mentioned this pull request Apr 24, 2024
Closed
5 tasks
@NicolasCwy NicolasCwy added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquestye marquestye marquestye approved these changes

@FergusMok FergusMok Awaiting requested review from FergusMok

@yuanxi1 yuanxi1 Awaiting requested review from yuanxi1

@mingyuanc mingyuanc Awaiting requested review from mingyuanc

Assignees

@NicolasCwy NicolasCwy

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasCwy @marquestye @FergusMok