[#12048] Prepare for migration testing #13089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FergusMok
commented
Apr 24, 2024
| private static final int BATCH_SIZE = 100; | ||
|
|
||
| private static final int MAX_BUFFER_SIZE = 1000; | ||
| private static final AtomicLong NUMBER_TO_MIGRATE = new AtomicLong(50); |
There was a problem hiding this comment.
Important parts to note
Comment on lines
+119
to
+122
| protected Query<Course> getFilterQuery() { | ||
| return ofy().load().type(teammates.storage.entity.Course.class) | ||
| .filter("isMigrated", false) | ||
| .order("-createdAt"); |
There was a problem hiding this comment.
Descending time of created
There was a problem hiding this comment.
Same for Oldest, where it's ascending
Comment on lines
+690
to
+692
| if (numberOfScannedKey == NUMBER_TO_MIGRATE) { | ||
| shouldContinue = false; | ||
| } |
There was a problem hiding this comment.
Stops once we hit the number to migrate
mingyuanc
approved these changes
Apr 24, 2024
NicolasCwy
added
c.Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
DataMigrationForCourseEntitySql50NewestandDataMigrationForCourseEntitySql50Oldest