Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Fix course migration script #13111

Merged

Conversation

NicolasCwy
Copy link
Contributor

@NicolasCwy NicolasCwy commented May 6, 2024

Part of #12048

Outline of Solution
Fix course related entity seed, migration and verification. Optimisation may be needed

Credits to @marquestye for helping out with verifying and testing instructor migration

@NicolasCwy NicolasCwy changed the base branch from master to v9-course-migration May 6, 2024 10:13
@NicolasCwy NicolasCwy requested a review from FergusMok May 6, 2024 10:16
@NicolasCwy NicolasCwy requested a review from marquestye May 6, 2024 10:16
@NicolasCwy NicolasCwy added s.ToReview The PR is waiting for review(s) c.Task Other non-user-facing works, e.g. refactoring, adding tests labels May 6, 2024
@NicolasCwy NicolasCwy force-pushed the fix-v9-course-migration branch 2 times, most recently from c076a8a to f6bb13e Compare May 6, 2024 10:27
Copy link
Contributor

@mingyuanc mingyuanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@FergusMok FergusMok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicolasCwy!

@FergusMok FergusMok merged commit 0798e80 into TEAMMATES:v9-course-migration Jun 22, 2024
1 check passed
@TEAMMATES TEAMMATES deleted a comment from nusoss-bot Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToReview The PR is waiting for review(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants