-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12508] Give respondents a way to reset a rubric question submission #13145
base: master
Are you sure you want to change the base?
Conversation
@NeoHW |
hey @NeoHW, do fix the failing tests before we review the PR, thanks! |
@NeoHW , thanks for the work on this. I think all other modals appear in the centre of the page. Could you modify yours to appear similarly? |
@NeoHW any updates? |
@domoberzin @mingyuanc , have updated the model accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, just a few tiny nits to fix
...nents/question-types/question-edit-answer-form/rubric-question-edit-answer-form.component.ts
Outdated
Show resolved
Hide resolved
...nts/question-types/question-edit-answer-form/rubric-question-edit-answer-form.component.html
Show resolved
Hide resolved
...nts/question-types/question-edit-answer-form/rubric-question-edit-answer-form.component.html
Outdated
Show resolved
Hide resolved
…rics-question' into ENH/12508/reset-rubrics-question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@NeoHW pls pass the CI, you can rerun the CI by pressing details and the rerun button is on the top right hand corner |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
1 similar comment
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Fixes #12508
Outline of Solution
reset choices
button.resetRubricAnswer
function to be called after confirmation of the action.UI changes: