-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12552] Session Copy Modal: Instructors able to select the Course that they are copying from #13149
base: master
Are you sure you want to change the base?
[#12552] Session Copy Modal: Instructors able to select the Course that they are copying from #13149
Conversation
I think standardizing the copies to have 'Copy of' prepended by default is okay, since the instructor would be able to edit this name in the modal, but @damithc would you like to weigh in on this change? |
@damithc Prof any updates? |
Hmm... Google docs allows the user to change the session name later, but we don't allow users to change the session name later. So, this strategy can lead to more severe problems than the current issue which is a mere inconvenience. For example, the user might not realize the name was prepended with a 'Copy of' until much later, when it is too late to even delete it. |
@damithc thanks for the input Prof, I think that's a fair approach to take for this @Respirayson could you implement it as described above? So there shouldn't be a 'Copy of' prepended but rather a warning/error within the popup when the name and course are the same |
Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 13 days). 🐌 😢 |
Fixes #12552
Outline of Solution
To fix this issue, whenever the instructor selects the same course that the feedback session belongs to, there'll be an alert that pops up to say that there already exists a session with the same name in that course.
TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.-.Google.Chrome.2024-08-03.14-53-40.mp4