[#12664] - Instructor's Student Records Page: Accessibility issue for comment buttons #13155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itstrueitstrueitsrealitsreal
suggested changes
Jul 29, 2024
There was a problem hiding this comment.
Good effort, I think these features will be useful for users with accessibility issues or who are using screen readers! Might need to make some small changes to pass tests though. Also, you might wanna sync up your fork and merge it into this branch to ensure that it's up to date.
src/web/app/components/comment-box/comment-edit-form/comment-edit-form.component.html
Outdated
Show resolved
Hide resolved
src/web/app/components/comment-box/comment-edit-form/comment-edit-form.component.html
Outdated
Show resolved
Hide resolved
dishenggg
requested changes
Jul 31, 2024
src/web/app/components/comment-box/comment-edit-form/comment-edit-form.component.html
Show resolved
Hide resolved
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12664
Outline of Solution
UI Changes