Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13122] Create cancel button for instructor request form #13156

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

NeoHW
Copy link
Contributor

@NeoHW NeoHW commented Jul 29, 2024

Fixes #13122

Outline of Solution

  • Add a Cancel button next to the Submit button so users can undo their form request and return to the homepage.
  • Added accessibility features to both cancel and submit button

UI changes

Screenshot 2024-07-29 at 11 18 46 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good that accessibility features for screen readers are also added.

Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingyuanc
Copy link
Contributor

@NeoHW same thing pls fix failing tests

@itstrueitstrueitsrealitsreal
Copy link
Contributor

Hi @mingyuanc, noticed that tests have been failing for recent PRs due to docker-compose being upgraded, should we prioritise the merging of #13159 before other PRs?

Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dishenggg dishenggg merged commit 3fddf47 into TEAMMATES:master Aug 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account Request Form: Adding Cancel button
5 participants