Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12375] Update phrasing of contact page #13157

Merged
merged 8 commits into from
Aug 7, 2024

Conversation

itstrueitstrueitsrealitsreal
Copy link
Contributor

Fixes #12375

Outline of Solution

Changed the text hyperlinked to the TEAMMATES GitHub on the contact page to be Project Website to be consistent with the phrasing used on the NUS-OSS projects page.

@dishenggg
Copy link
Contributor

One thing to note is that our repository readme has it as TEAMMATES Developer Web Site so this could possibly generate more confusion? I am leaning towards just calling it Teammates Github, maybe others can pitch in as well.

@itstrueitstrueitsrealitsreal
Copy link
Contributor Author

itstrueitstrueitsrealitsreal commented Jul 31, 2024

@dishenggg oh, I failed to consider that. How would this look instead? I also added icons to reduce confusion.
image

Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mingyuanc mingyuanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingyuanc mingyuanc merged commit 6d4f9f4 into TEAMMATES:master Aug 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Developer Website link in Contact page
4 participants