feat: use r/demo/profile for gno user info
#1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
n0izn0iz
requested changes
Aug 6, 2024
There was a problem hiding this comment.
I think we shouldn't add a new hook and instead adapt the existing
- useNSPrimaryAlias (returns r/demo/users name)
- useNSUserInfo (returns relevant fields in r/demo/profiles)
without changing interfaces.
This way, everything we did before will be automatically supported
n0izn0iz
changed the title
n0izn0iz
requested changes
Aug 7, 2024
There was a problem hiding this comment.
this is much better, thanks :)
one last thing:
we should try to keep changes minimal (remove dev artifacts)
this makes the changes more atomic, make reviews easier and prevents including unwanted changes
thus can you revert the unneeded changes in
- packages/components/images/AvatarWithFrame.tsx
- packages/screens/UserPublicProfile/components/UPPIntro.tsx
pls
Signed-off-by: Norman Meier <norman@samourai.coop>
n0izn0iz
changed the title
n0izn0iz
changed the title
r/demo/profile for gno user info
Signed-off-by: Norman Meier <norman@samourai.coop>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1244
Use Gno r/demo/profile for UPP page. Here are some results: