Allow updating binary header fields in SEG-Y factory. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 19, 2024 15:28
The create_binary_header function in factory.py now accepts an optional update parameter. This is a dictionary that contains binary header fields which need to be modified. The function will update these fields with the values specified in the update dictionary before returning the encoded binary header.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 94.81% 94.84% +0.03%
==========================================
Files 47 47
Lines 2062 2074 +12
Branches 245 247 +2
==========================================
+ Hits 1955 1967 +12
Misses 81 81
Partials 26 26 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
create_binary_headerfunction in factory now accepts an optionalupdateparameter. This dictionary contains binary header fields that need to be modified from default. The function will update these fields with the values specified in the update dictionary before returning the encoded binary header.