Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply endianness override if spec was provided #191

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

tasansal
Copy link
Contributor

No description provided.

@tasansal tasansal added the bug Something isn't working label Sep 25, 2024
@tasansal tasansal self-assigned this Sep 25, 2024
Updated the logic for determining endianness to correctly prioritize user settings. This ensures the inferred endianness is only used if both the provided specification and user settings do not specify it.
@tasansal tasansal merged commit 80b59cc into main Sep 25, 2024
30 checks passed
@tasansal tasansal deleted the endian-override-with-spec branch September 25, 2024 19:53
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.16%. Comparing base (6347f56) to head (915fc67).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/segy/file.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   95.25%   95.16%   -0.09%     
==========================================
  Files          48       48              
  Lines        2191     2193       +2     
  Branches      261      262       +1     
==========================================
  Hits         2087     2087              
- Misses         79       81       +2     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant