Override Numpy's copy method to SegyArray to ensure uninterpreted bytes are preserved.
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 'copy' method, which maintains raw binary data and padding bytes, has been added to the SegyArray class in arrays.py. This is essential for SEG-Y data processing where unparsed fields are present but preserving raw binary data integrity is crucial.
tasansal
changed the title
SegyArray to ensure uninterpreted bytes are preserved.SegyArray to ensure uninterpreted bytes are preserved.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 94.75% 94.59% -0.17%
==========================================
Files 37 37
Lines 1660 1664 +4
Branches 205 205
==========================================
+ Hits 1573 1574 +1
- Misses 67 70 +3
Partials 20 20 ☔ View full report in Codecov by Sentry. |
added 2 commits
April 4, 2024 19:33
The test has been added to confirm that the copy method of SegyArray can successfully copy a segy array with the exact underlying buffer. The test also verifies that the memory between the original segy array and its copy are not shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
copymethod, which maintains raw binary data and padding bytes, has been added to theSegyArray. This is essential for SEG-Y data processing where unparsed fields are present and preserving raw (uninterpreted) binary data integrity is crucial.