Maintenance/add example #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were there any changes compared to the example in react-native-theoplayer? |
|
This example is only for android and ios for now, the UI itself in App.tsx is also a bit more basic but most of it is the same. |
|
It feels weird to have two examples for what is supposed to be a cross-platform UI. 😅 Are there any plans for merging the two examples into one that works on web, Android and iOS? |
|
Okay, I understand now. You want an example inside your repo so you can quickly test your changes while developing. Then this is fine. 👍 |
Jeroen-Veltmans
force-pushed
the
maintenance/add-example
branch
from
c681162
to
332517e
Compare
Jeroen-Veltmans
force-pushed
the
maintenance/add-example
branch
from
332517e
to
41fb992
Compare
tvanlaerhoven
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example project to easily test the project.