Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/seekable not updated for mp4 sourcechange #30

Merged
merged 4 commits into from
May 15, 2024

Conversation

wjoosen
Copy link
Contributor

@wjoosen wjoosen commented May 15, 2024

This PR fixes two issues

  1. An issue where due to the lack of progress events firing (as expected) for MP4 assets, the seekable state is not updated if you switch to an MP4 source on the same player instance. This messes up the SeekBar, since the thumb is rendered at a percentage into the timeline that is calculated using seekable.end. Without this fix, the SeekBar will still use the seekable.end of the previous source.
  2. An issue where the SkipButton components are not rendered on the Sender when switching sources during a Chromecast session, due to the fact that buffered and seekable are not populated yet if the source change happened on the receiver.

@wjoosen wjoosen merged commit fade31c into develop May 15, 2024
1 check passed
@wjoosen wjoosen deleted the bugfix/seekable-not-updated-for-mp4-sourcechange branch May 15, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants