SNAP-618: update to hbase 0.98.X to be compatible with Spark's version #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added dependencies to hbase 0.98.X with excludes like in Spark and explicit inclusion of htrace-core required at runtime * corrected the Comparator hierarchy to now inherit from KVComparator with the interfaces like SerializedComparator now being abstract classes; fixed a number of overrides to be consistent with the new expected methods (see RawBytesComparator in hbase code for an example) * as a result of changing interfaces to abstract base, DelegatingSerializedComparator now extends CompositeSerializedComparator (which is somewhat out of place but required) * corrected the HFile creation to use HFileContextBuilder for the new HFileContext as required in new APIs * added an intermediate BytesComparator to wrap a SerializedCompator as a thin veneer to provide a Comparator<byte[]> on top of Comparator<Cell> that SerializedCompator now implements (due to extending KVComparator) * commented out SchemaMetrics initialization which is now gone and should not be required with metrics2
|
@hbhanawat Merging this PR. Will take care of any comments, if they are provided, subsequently. |
sumwale
pushed a commit
to sumwale/snappy-store
that referenced
this pull request
Apr 30, 2021
SNAP-618: update to hbase 0.98.X to be compatible with Spark's version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow inclusion of hbase in our assembly jar avoiding user to include the jar and its dependencies explicitly. It also avoids the problems that will arise if some app were to use hbase deps of Spark (which comes in from hive-client) with HDFS support of GemXD.
now being abstract classes; fixed a number of overrides to be consistent with the new expected methods
(see RawBytesComparator in hbase code for an example)
CompositeSerializedComparator (which is somewhat out of place but required)
Comparator<byte[]> on top of Comparator that SerializedCompator now implements (due to extending KVComparator)