[SNAP 3104] Showing external hive metastore tables as part of HIVETABLES VTI #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 18, 2019 13:21
as part of SYS.HIVETABLES VTI. Pending: Changes are tested by picking first available snappysession from ConnectionIdToSnappySession map instead of picking the correct SnappySession for given connection id.
`ExternalHiveTablesCollectorFunction`. - added copyright headers
…tion which will be used to retrieve hive tables available in current schema.
vatsalmevada
commented
Nov 20, 2019
Comment on lines
+58
to
+64
| @Override | ||
| public boolean optimizeForWrite() { | ||
| return false; | ||
| } | ||
|
|
||
| //todo[vatsal] : verify this return value | ||
| @Override | ||
| public boolean isHA() { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Need to verify these return values.
vatsalmevada
commented
Nov 20, 2019
|
|
||
| @Override | ||
| public void toData(DataOutput out) throws IOException { | ||
| InternalDataSerializer.writeArrayLength(tablesMetadata.size(), out); |
There was a problem hiding this comment.
Serializing only those fields from ExternalTableMetadata which are required for HiveTablesVTI.
added 6 commits
November 20, 2019 19:15
sumwale
force-pushed
the
snappy/master
branch
2 times, most recently
from
337768c to
ec453a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Showing external hive metastore tables as part of HIVETABLES VTI
Approach
Keeping a flag
hiveSessionInitializedas part of the profile of the lead nodewith the default value set to
false.When the hive session is initialized on the lead node, we set this flag to
trueand distribute the updated profile.When
SYS.HIVETABLESVIT is executed on a server node, the server node checkswhether
hiveSessionInitializedis set totruein lead's profile. If it isset to
trueit executesExternalHiveTablesCollectorFunctionon the lead nodeto fetch the metadata of hive tables available on external hive metastore.
ExternalHiveTablesCollectorFunctionis only executed whenhiveSessionInitializedis set totrueto avoid unnecessary remote functioncall.
Note that server need to fetch these details from the leader node as the hive
session is available only one leader.
Patch testing
precheckin -PstoreManually tested. Will add automated coverage.
Other PRs
TIBCOSoftware/snappydata#1472