Snap 2603 : Display list of Global Temporary Views/Tables with relevant details on Snappy UI. #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with relevant details on Snappy UI. - Adding resource named AllGlobalTemporaryViewsResource.scala for getting global temporary details. - Adding resource path "allglobaltempviews" - Updating Snappy Dashboard HTML page for displaying list of all global temporary views/tables. - Updated getStatsFromAllServers to fetch and return the global temporary views details. - Relevant code changes in TableStatsProviderService, SnappyTableStatsProviderService and SnappyThinConnectorTableStatsProvider.
- Code changes for displaying temporary global table's Field details.
sumwale
reviewed
Apr 10, 2019
| val globalTempSchema: String = "global_temp" | ||
| val gblTempViewList = snappySessionCatalog.listTables(globalTempSchema) | ||
|
|
||
| if (gblTempViewList.isEmpty) { |
There was a problem hiding this comment.
Temporarily creating a session just for listing the tables is quite inefficient. Can't this be included as part of regular tableTypesMap created in getStatsFromAllServers (where tableType can be GLOBAL_TEMPORARY)?
To get the list without session use: SnappyContext.sharedState(sc = null).globalTempViewManager.listViewNames("*"). This avoids unnecessary creation of a SnappyContext object which is expensive and not required. Secondly this list can just be appended to the list of "hiveTables" in getStatsFromAllServers with tableType=GLOBAL_TEMPORARY. Display can use the tableType to distinguish. This avoids separate calls for this as well as the new message.
|
Can one of the admins verify this patch? |
sumwale
force-pushed
the
master
branch
5 times, most recently
from
8b43301 to
2b254d9
Compare
sumwale
force-pushed
the
master
branch
5 times, most recently
from
2c254f0 to
0f2888f
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
a466d26 to
ea127bd
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
99ec79c to
c7b84fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Requirements:
Changes:
Patch testing
ReleaseNotes.txt changes
Other PRs
Store: TIBCOSoftware/snappy-store#460
Spark: TIBCOSoftware/snappy-spark#135