-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTELLIJ_TEST_PATTERN doesn't work with multi module projects #696
Comments
Hmm, but usually all classes are compiled into |
I'm not sure if this is project specific but what I'm seeing in the multi module project I'm working in is that classes are being written to a path consisting of the module name, with a sub path consisting of the package name. E.g. if the module was called 'foo' and the package was 'com.foo.bar' I'd see this path: |
Okay, I played around a little bit and I can reproduce it with a plain IntelliJ project without any build tool 🤔 Then it seems to create a subfolder with the method name... I guess we could just adjust the pattern to |
…with multi-module projects. Issue TNG#696
…with multi-module projects. Issue TNG#696 Signed-off-by: Cook, Jeremy <jeremy.cook@oracle.com>
Plain IntelliJ projects (i.e. set up without any build tool) now seem to use the pattern `out/test/$MODULE_NAME` to compile class files to. Since we can safely assume that everything built into `out/test` belongs to the test scope, we can adjust the IntelliJ pattern to exclude everything in `.*/out/test/.*` to catch all cases, no matter if set up with a build tool or directly with IntelliJ. Issue: TNG#696 Signed-off-by: Cook, Jeremy <jeremy.cook@oracle.com>
Plain IntelliJ projects (i.e. set up without any build tool) now seem to use the pattern `out/test/$MODULE_NAME` to compile class files to. Since we can safely assume that everything built into `out/test` belongs to the test scope, we can adjust the IntelliJ pattern to exclude everything in `.*/out/test/.*` to catch all cases, no matter if set up with a build tool or directly with IntelliJ. Issue: TNG#696 Signed-off-by: Cook, Jeremy <jeremy.cook@oracle.com>
Plain IntelliJ projects (i.e. set up without any build tool) now seem to use the pattern `out/test/$MODULE_NAME` to compile class files to. Since we can safely assume that everything built into `out/test` belongs to the test scope, we can adjust the IntelliJ pattern to exclude everything in `.*/out/test/.*` to catch all cases, no matter if set up with a build tool or directly with IntelliJ. Issue: TNG#696 Signed-off-by: Cook, Jeremy <jeremy.cook@oracle.com>
Firstly, thanks for creating this library. It's an awesome and very useful tool.
I've come across a small issue when trying to exclude test classes when importing classes. It seems that the IntelliJ test pattern in
ImportOption.java
doesn't work with multi-module projects. In the project I work in I had to use.*/out/test/.*
to exclude test classes properly. Would be possible to look into this and possibly expand the pattern to support multi module projects?The text was updated successfully, but these errors were encountered: