Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rule to prevent dependencies on upper packages #352

Merged
merged 1 commit into from
May 8, 2020

Conversation

codecholeric
Copy link
Collaborator

@codecholeric codecholeric commented May 3, 2020

To keep packages splittable into separate artifacts in a clean way it can make sense to forbid dependencies on any parent package, as that prevents the possibility to cleanly separate packages on the same sub-package level.

@codecholeric codecholeric force-pushed the feature/library/no-access-to-upper-package branch from 0753d36 to 7ef945f Compare May 3, 2020 19:16
@codecholeric codecholeric force-pushed the feature/library/no-access-to-upper-package branch 2 times, most recently from 76b6326 to 7410db3 Compare May 8, 2020 20:51
To keep packages splittable into separate artifacts in a clean way it can make sense to forbid dependencies on any parent package, as that prevents the possibility to cleanly separate packages on the same sub-package level.

Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
@codecholeric codecholeric force-pushed the feature/library/no-access-to-upper-package branch from 7410db3 to e860986 Compare May 8, 2020 20:51
@codecholeric codecholeric changed the title add rule to prevent accesses to upper packages add rule to prevent dependencies on upper packages May 8, 2020
@codecholeric codecholeric merged commit 43a475a into master May 8, 2020
@codecholeric codecholeric deleted the feature/library/no-access-to-upper-package branch May 8, 2020 21:07
codecholeric added a commit that referenced this pull request Feb 21, 2021
To keep packages splittable into separate artifacts in a clean way it can make sense to forbid dependencies on any parent package, as that prevents the possibility to cleanly separate packages on the same sub-package level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant