Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #41 #43

Merged
merged 3 commits into from
Nov 15, 2017
Merged

Issue #41 #43

merged 3 commits into from
Nov 15, 2017

Conversation

stefluhh
Copy link

@stefluhh stefluhh commented Nov 12, 2017

Hi,

this PR implements everything that should be required in order to resolve #41.
Please review the changes. I was unsure whether to call the negation methods haveXyzNot or notHave as you suggested, since I had already started naming the methods haveSimpleNamingNotEndingWith and it was merged like that. I have no problems with renaming all methods respectively if wanted.

Stef

I hereby agree to the terms of the ArchUnit Contributor License Agreement.

- Implemented ClassesThat for haveSimpleNameStartingWith/EndingWith/Containing and negations
- Implemented ClassesShould for haveSimpleNameContaining and negation
- Added an example IntegrationTest
- Polished Javadoc

Issue #41
@codecholeric
Copy link
Collaborator

Ah, thank you so much 😃
The naming seems fine to me, I would have strove for consistency with haveNameMatching, and that is how you named them, so I fully agree 😉
I'll look into that in detail during the next days (when I find the time) and get back to you / merge it...

@codecholeric
Copy link
Collaborator

Looking good, thanks again 😃

@codecholeric codecholeric merged commit f75db33 into TNG:master Nov 15, 2017
codecholeric added a commit that referenced this pull request Nov 18, 2017
… for that()...simpleName...() and added NamingConventionIntegrationTest to assert the behavior of those examples for the future.

Issue: #41
codecholeric added a commit that referenced this pull request Feb 21, 2021
Adds the missing fluent API to finish #41 

Resolves #41
codecholeric added a commit that referenced this pull request Feb 21, 2021
… for that()...simpleName...() and added NamingConventionIntegrationTest to assert the behavior of those examples for the future.

Issue: #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend syntax for simple class name handling
2 participants