Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing apple.security to SecurityTest. Resolves #67 #68

Merged
merged 1 commit into from
May 15, 2018

Conversation

DennisRippinger
Copy link
Contributor

Also fixes a problem related to running JUnit Tests from IntelliJ on Mac systems. IntelliJ resides in a folder IntelliJ App (mind the space) which executes the JUnit tests and adds therefore its own Jars to the classpath. When converted from an URL into an URI we recieve an illegal character exception. The fix was to UrlEscape the path variable within the newUrl method.

I hereby agree to the terms of the ArchUnit Contributor License Agreement.

Also fixes a problem related to running JUnit Tests from IntelliJ on Mac
systems. IntelliJ resides in a folder `IntelliJ App` (mind the space)  which executes the
JUnit tests and adds therefore its own Jars to the classpath. When
converted from an URL into an URI we recieve an illegal character
exception. The fix was to UrlEscape the path variable within the `newUrl` method.

Signed-off-by: Dennis Rippinger <dennis.rippinger@gmail.com>
@codecholeric
Copy link
Collaborator

Thank you so much 😃
I actually had noticed that problem with URLs with spaces a while ago and forgot to fix it, so I'm happy you brought it up again!! (I'm gonna add a small test for the bug, to prevent regression...)

@codecholeric codecholeric merged commit 1237623 into TNG:master May 15, 2018
codecholeric added a commit that referenced this pull request Feb 21, 2021
Fixed missing `apple.security` to SecurityTest. Resolves #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants