added beImmutable() to ArchConditions #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! But I'd probably change the wording from beImmutable to, e.g., haveOnlyFinalFields (as a field can be final, but still be internally mutated). |
|
name changed according to your comment ;) |
|
Thanks for your PR!! I agree with @hankem, "immutable" would have been misleading, since a class can still heavily mutate its state (e.g. |
codecholeric
added a commit
that referenced
this pull request
Jul 1, 2018
…oring. Issue: #86 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
|
I love this one @bgalek . Comes in very handy especially for enforcement of immutability for |
|
@SteluHH I'm glad that my contribution is appreciated! 😎 Keep up the good work :) |
codecholeric
added a commit
that referenced
this pull request
Feb 21, 2021
added haveOnlyFinalFields() to ArchConditions
codecholeric
added a commit
that referenced
this pull request
Feb 21, 2021
…oring. Issue: #86 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've made new assertion to check if class is immutable (no mutable fields).
For me it would be useful. If You like it, please review my PR, I'm happy to update it if needed ;)
Feature wasn't discussed before so don't hesitate to decline the PR - I won't mind.
It was fun making a contribution to this project, keep up the good work!
I hereby agree to the terms of the ArchUnit Contributor License Agreement.