Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support comments in archunit_ignore_patterns.txt #88

Merged
merged 3 commits into from
Jul 10, 2018
Merged

Support comments in archunit_ignore_patterns.txt #88

merged 3 commits into from
Jul 10, 2018

Conversation

bedla
Copy link
Contributor

@bedla bedla commented Jul 10, 2018

Hi,
it would be nice to comment lines with description of ignored patterns. Pls take a look and say what do you think. Looks like that "# " is good enough :]
Thx
Ivos

@codecholeric
Copy link
Collaborator

Wow, thanks for your next PR 😃
Looks good to me, the only thing I'm wondering is if it's necessary to enforce that whitespace after # ?
I guess most people will add it anyway, but that the line suddenly doesn't count as comment anymore, if I write #ignore that line seems kind of surprising?

@hankem
Copy link
Member

hankem commented Jul 10, 2018

I'd also assume that # should be sufficient for a comment.

@bedla
Copy link
Contributor Author

bedla commented Jul 10, 2018

i have looked how regexp buddy solves comments and just copied it. no problem to change it ;]

@bedla
Support comments in archunit_ignore_patterns.txt
4d54086 
Signed-off-by: Ivo Smid <ivo.smid@gmail.com>
@bedla bedla force-pushed the ignorepatterncomment branch from b8dca11 to 4d54086 Compare July 10, 2018 11:59
@codecholeric
Review: Make test assertion consistent with the rest -> AssertJ's ass…
e09d823 
…ertThatThrownBy is nice, but with Java 7 there is still much boiler plate code, and all other places assert exceptions in a different way, so to be consistent I've changed this.

Issue: TNG#88
Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
@codecholeric
Review: Add an example of a comment to the ArchUnit user guide
30fc684 
Issue: TNG#88
Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
@codecholeric
Copy link
Collaborator

Thanks for the adjustment! I've made a small change in the test, because I like consistency (even though, especially with Java 8, the AssertJ assertThatThrownBy approach is definitely nicer 😉; with Java 7, cause of all the boilerplate, I have no strong opinion)
Also I've added this to the user guide.
Thanks a lot for contributing!! 😄

@codecholeric codecholeric merged commit df451e2 into TNG:master Jul 10, 2018
@bedla
Copy link
Contributor Author

bedla commented Jul 10, 2018

thx for merge. i am happy to help :)

@codecholeric codecholeric added this to the 0.9.0 milestone Aug 19, 2018
codecholeric added a commit that referenced this pull request Feb 21, 2021
@codecholeric
Review: Make test assertion consistent with the rest -> AssertJ's ass…
cb7d360 
…ertThatThrownBy is nice, but with Java 7 there is still much boiler plate code, and all other places assert exceptions in a different way, so to be consistent I've changed this.

Issue: #88
Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
codecholeric added a commit that referenced this pull request Feb 21, 2021
@codecholeric
Review: Add an example of a comment to the ArchUnit user guide
73bf9fe 
Issue: #88
Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
codecholeric added a commit that referenced this pull request Feb 21, 2021
@codecholeric
Merge pull request #88 from bedla/ignorepatterncomment
7250b53 
Support comments in archunit_ignore_patterns.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bedla @codecholeric @hankem