fixed class hierarchy resolution #91
Conversation
Hi, I encountered a problem with the resolution of type hierarchies, where a base class in a quite deep hierarchy from a framework was not resolved correctly. I debugged this a lot and think this change should fix it. It seems quite obvious to me that this is wrong, so I decided to just provide a minimal pull request. It's obvious because resolving only the interfaces for a superclass does not add its own superclass-hierarchy to the context. So, it can happen that not the whole hierarchy is resolved. I would also provide a test case for that, but unfortunately I'm not able to git push at work. I did this change with github's online editor.
…rt would not be resolved correctly. Issue: #91 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
…rt would not be resolved correctly. Issue: #91 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
|
Thank you so much for debugging and reporting this!! This is indeed an error, I guess it went unnoticed for so long, because it only shows if you have deeply nested super classes missing from your import. I've taken your fix over in 76dab49, added a test for this and could reproduce it (with sufficiently many levels of hierarchy and the classes missing from the original import 😉) |
|
BTW: A quick "it's fixed with 0.8.3" would be appreciated, I'll keep this PR open until then 😉 |
|
It's through 😉 |
|
Thanks! Version 0.8.3 is working for me. |
…rt would not be resolved correctly. Issue: #91 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
Hi,
I encountered a problem with the resolution of type hierarchies, where a base class in a quite deep hierarchy from a framework was not resolved correctly.
I debugged this a lot and think this change should fix it. It seems quite obvious to me that this is wrong, so I decided to just provide a minimal pull request. It's obvious because resolving only the interfaces for a superclass does not add its own superclass-hierarchy to the context. So, it can happen that not the whole hierarchy is resolved.
I would also provide a test case for that, but unfortunately I'm not able to git push at work. I did this change with github's online editor. I can also not build/test this here, so please excuse that I did not completely follow the contribution guidelines. Maybe you can just see this as a bug report with a solution suggestion.