make importPackages("") and importClasspath(..) consistent
#954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
So far `ClassFileImporter.importPackages("")` would only return classes returned by `ClassLoader.getResources("")`, but not other classes derived from the configured URL classpath (as done for other prefixes like `com`, which would be searched through the whole classpath as well). The reason is that this corner case has been overlooked in `NormalizedResourceName.startsWith(..)`. I.e. if the prefix is empty, then the resource would only be included if it starts with a `/`, but resources in archives do not start with a `/`.
Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
codecholeric
force-pushed
the
support-importing-default-package
branch
from
fafabb3
to
2c66196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far
ClassFileImporter.importPackages("")would only return classes that returns, but not classes derived from the set classpath. The reason is that this corner case has been overlooked inNormalizedResourceName.startsWith(..). I.e. if the prefix is empty, then the resource would only be included if it starts with a/, but resources in archives do not start with a/.