Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional grouping of big tables #168

Closed
nikowitt opened this issue Nov 11, 2015 · 12 comments
Closed

Additional grouping of big tables #168

nikowitt opened this issue Nov 11, 2015 · 12 comments
Labels
core enhancement HTML Report
Milestone
v0.10.0

Comments

@nikowitt
Copy link
Contributor

And again :)

Test Class: com.sobis.pirsjava.tests.security.IKeywordSecurityTest

Scenario: create keyword

Given logged in user
When user creates entity
Then jafaccessdeniedexception thrown

Cases:

    |   # | userName       | clazz                      | isExceptionThrown | Status  |
    +-----+----------------+----------------------------+-------------------+---------+
    |   1 | "system"       | customkeyword2             | is not            | Success |
    |   2 | "PIRS Admin"   | customkeyword2             | is not            | Success |
    |   3 | "PIRS Creator" | customkeyword2             | is                | Success |
    |   4 | "PIRS Reader"  | customkeyword2             | is                | Success |
    |   5 | "system"       | customsuperbox3            | is not            | Success |
    |   6 | "PIRS Admin"   | customsuperbox3            | is not            | Success |
    |   7 | "PIRS Creator" | customsuperbox3            | is                | Success |
    |   8 | "PIRS Reader"  | customsuperbox3            | is                | Success |
    |   9 | "system"       | customsuperbox4            | is not            | Success |
    |  10 | "PIRS Admin"   | customsuperbox4            | is not            | Success |
    |  11 | "PIRS Creator" | customsuperbox4            | is                | Success |
    |  12 | "PIRS Reader"  | customsuperbox4            | is                | Success |
    |  13 | "system"       | customkeyword4             | is not            | Success |
    |  14 | "PIRS Admin"   | customkeyword4             | is not            | Success |
    |  15 | "PIRS Creator" | customkeyword4             | is                | Success |
    |  16 | "PIRS Reader"  | customkeyword4             | is                | Success |
    |  17 | "system"       | system                     | is not            | Success |
    |  18 | "PIRS Admin"   | system                     | is not            | Success |
    |  19 | "PIRS Creator" | system                     | is                | Success |
    |  20 | "PIRS Reader"  | system                     | is                | Success |
    |  21 | "system"       | tsfromcustomercontrol      | is not            | Success |
    |  22 | "PIRS Admin"   | tsfromcustomercontrol      | is not            | Success |
    |  23 | "PIRS Creator" | tsfromcustomercontrol      | is                | Success |
    |  24 | "PIRS Reader"  | tsfromcustomercontrol      | is                | Success |
    |  25 | "system"       | customercategory           | is not            | Success |
    |  26 | "PIRS Admin"   | customercategory           | is not            | Success |
    |  27 | "PIRS Creator" | customercategory           | is                | Success |
    |  28 | "PIRS Reader"  | customercategory           | is                | Success |
    |  29 | "system"       | customsuperbox2            | is not            | Success |
    |  30 | "PIRS Admin"   | customsuperbox2            | is not            | Success |
    |  31 | "PIRS Creator" | customsuperbox2            | is                | Success |
    |  32 | "PIRS Reader"  | customsuperbox2            | is                | Success |
    |  33 | "system"       | customerrevision           | is not            | Success |
    |  34 | "PIRS Admin"   | customerrevision           | is not            | Success |
    |  35 | "PIRS Creator" | customerrevision           | is                | Success |
    |  36 | "PIRS Reader"  | customerrevision           | is                | Success |
    |  37 | "system"       | actionitempriority         | is not            | Success |
    |  38 | "PIRS Admin"   | actionitempriority         | is not            | Success |
    |  39 | "PIRS Creator" | actionitempriority         | is                | Success |
    |  40 | "PIRS Reader"  | actionitempriority         | is                | Success |
    |  41 | "system"       | taglabel                   | is not            | Success |
    |  42 | "PIRS Admin"   | taglabel                   | is not            | Success |
    |  43 | "PIRS Creator" | taglabel                   | is                | Success |
    |  44 | "PIRS Reader"  | taglabel                   | is                | Success |
    |  45 | "system"       | applicationcode            | is not            | Success |
    |  46 | "PIRS Admin"   | applicationcode            | is not            | Success |
    |  47 | "PIRS Creator" | applicationcode            | is                | Success |
    |  48 | "PIRS Reader"  | applicationcode            | is                | Success |
    |  49 | "system"       | supplierstatus             | is not            | Success |
    |  50 | "PIRS Admin"   | supplierstatus             | is not            | Success |
    |  51 | "PIRS Creator" | supplierstatus             | is                | Success |
    |  52 | "PIRS Reader"  | supplierstatus             | is                | Success |
    |  53 | "system"       | reference                  | is not            | Success |
    |  54 | "PIRS Admin"   | reference                  | is not            | Success |
    |  55 | "PIRS Creator" | reference                  | is                | Success |
    |  56 | "PIRS Reader"  | reference                  | is                | Success |
    |  57 | "system"       | customkeyword5             | is not            | Success |
    |  58 | "PIRS Admin"   | customkeyword5             | is not            | Success |
    |  59 | "PIRS Creator" | customkeyword5             | is                | Success |
    |  60 | "PIRS Reader"  | customkeyword5             | is                | Success |
    |  61 | "system"       | suppliercategory           | is not            | Success |
    |  62 | "PIRS Admin"   | suppliercategory           | is not            | Success |
    |  63 | "PIRS Creator" | suppliercategory           | is                | Success |
    |  64 | "PIRS Reader"  | suppliercategory           | is                | Success |
    |  65 | "system"       | language                   | is not            | Success |
    |  66 | "PIRS Admin"   | language                   | is not            | Success |
    |  67 | "PIRS Creator" | language                   | is                | Success |
    |  68 | "PIRS Reader"  | language                   | is                | Success |
    |  69 | "system"       | docformat                  | is not            | Success |
    |  70 | "PIRS Admin"   | docformat                  | is not            | Success |
    |  71 | "PIRS Creator" | docformat                  | is                | Success |
    |  72 | "PIRS Reader"  | docformat                  | is                | Success |
    |  73 | "system"       | customsuperbox5            | is not            | Success |
    |  74 | "PIRS Admin"   | customsuperbox5            | is not            | Success |
    |  75 | "PIRS Creator" | customsuperbox5            | is                | Success |
    |  76 | "PIRS Reader"  | customsuperbox5            | is                | Success |
    |  77 | "system"       | doctype                    | is not            | Success |
    |  78 | "PIRS Admin"   | doctype                    | is not            | Success |
    |  79 | "PIRS Creator" | doctype                    | is                | Success |
    |  80 | "PIRS Reader"  | doctype                    | is                | Success |
    |  81 | "system"       | commenttocustomercontrol   | is not            | Success |
    |  82 | "PIRS Admin"   | commenttocustomercontrol   | is not            | Success |
    |  83 | "PIRS Creator" | commenttocustomercontrol   | is                | Success |
    |  84 | "PIRS Reader"  | commenttocustomercontrol   | is                | Success |
    |  85 | "system"       | customkeyword1             | is not            | Success |
    |  86 | "PIRS Admin"   | customkeyword1             | is not            | Success |
    |  87 | "PIRS Creator" | customkeyword1             | is                | Success |
    |  88 | "PIRS Reader"  | customkeyword1             | is                | Success |
    |  89 | "system"       | actionitemstatus           | is not            | Success |
    |  90 | "PIRS Admin"   | actionitemstatus           | is not            | Success |
    |  91 | "PIRS Creator" | actionitemstatus           | is                | Success |
    |  92 | "PIRS Reader"  | actionitemstatus           | is                | Success |
    |  93 | "system"       | supplierrevision           | is not            | Success |
    |  94 | "PIRS Admin"   | supplierrevision           | is not            | Success |
    |  95 | "PIRS Creator" | supplierrevision           | is                | Success |
    |  96 | "PIRS Reader"  | supplierrevision           | is                | Success |
    |  97 | "system"       | commenttosuppliercontrol   | is not            | Success |
    |  98 | "PIRS Admin"   | commenttosuppliercontrol   | is not            | Success |
    |  99 | "PIRS Creator" | commenttosuppliercontrol   | is                | Success |
    | 100 | "PIRS Reader"  | commenttosuppliercontrol   | is                | Success |
    | 101 | "system"       | contacttype                | is not            | Success |
    | 102 | "PIRS Admin"   | contacttype                | is not            | Success |
    | 103 | "PIRS Creator" | contacttype                | is                | Success |
    | 104 | "PIRS Reader"  | contacttype                | is                | Success |
    | 105 | "system"       | correspondencecategory     | is not            | Success |
    | 106 | "PIRS Admin"   | correspondencecategory     | is not            | Success |
    | 107 | "PIRS Creator" | correspondencecategory     | is                | Success |
    | 108 | "PIRS Reader"  | correspondencecategory     | is                | Success |
    | 109 | "system"       | customsuperbox1            | is not            | Success |
    | 110 | "PIRS Admin"   | customsuperbox1            | is not            | Success |
    | 111 | "PIRS Creator" | customsuperbox1            | is                | Success |
    | 112 | "PIRS Reader"  | customsuperbox1            | is                | Success |
    | 113 | "system"       | tsfromsuppliercontrol      | is not            | Success |
    | 114 | "PIRS Admin"   | tsfromsuppliercontrol      | is not            | Success |
    | 115 | "PIRS Creator" | tsfromsuppliercontrol      | is                | Success |
    | 116 | "PIRS Reader"  | tsfromsuppliercontrol      | is                | Success |
    | 117 | "system"       | revision                   | is not            | Success |
    | 118 | "PIRS Admin"   | revision                   | is not            | Success |
    | 119 | "PIRS Creator" | revision                   | is                | Success |
    | 120 | "PIRS Reader"  | revision                   | is                | Success |
    | 121 | "system"       | tstocustomercontrol        | is not            | Success |
    | 122 | "PIRS Admin"   | tstocustomercontrol        | is not            | Success |
    | 123 | "PIRS Creator" | tstocustomercontrol        | is                | Success |
    | 124 | "PIRS Reader"  | tstocustomercontrol        | is                | Success |
    | 125 | "system"       | actionitemcategory         | is not            | Success |
    | 126 | "PIRS Admin"   | actionitemcategory         | is not            | Success |
    | 127 | "PIRS Creator" | actionitemcategory         | is                | Success |
    | 128 | "PIRS Reader"  | actionitemcategory         | is                | Success |
    | 129 | "system"       | commentfromcustomercontrol | is not            | Success |
    | 130 | "PIRS Admin"   | commentfromcustomercontrol | is not            | Success |
    | 131 | "PIRS Creator" | commentfromcustomercontrol | is                | Success |
    | 132 | "PIRS Reader"  | commentfromcustomercontrol | is                | Success |
    | 133 | "system"       | customkeyword3             | is not            | Success |
    | 134 | "PIRS Admin"   | customkeyword3             | is not            | Success |
    | 135 | "PIRS Creator" | customkeyword3             | is                | Success |
    | 136 | "PIRS Reader"  | customkeyword3             | is                | Success |
    | 137 | "system"       | docstatus                  | is not            | Success |
    | 138 | "PIRS Admin"   | docstatus                  | is not            | Success |
    | 139 | "PIRS Creator" | docstatus                  | is                | Success |
    | 140 | "PIRS Reader"  | docstatus                  | is                | Success |
    | 141 | "system"       | commentfromsuppliercontrol | is not            | Success |
    | 142 | "PIRS Admin"   | commentfromsuppliercontrol | is not            | Success |
    | 143 | "PIRS Creator" | commentfromsuppliercontrol | is                | Success |
    | 144 | "PIRS Reader"  | commentfromsuppliercontrol | is                | Success |
    | 145 | "system"       | customerstatus             | is not            | Success |
    | 146 | "PIRS Admin"   | customerstatus             | is not            | Success |
    | 147 | "PIRS Creator" | customerstatus             | is                | Success |
    | 148 | "PIRS Reader"  | customerstatus             | is                | Success |
    | 149 | "system"       | tsmetadocaction            | is not            | Success |
    | 150 | "PIRS Admin"   | tsmetadocaction            | is not            | Success |
    | 151 | "PIRS Creator" | tsmetadocaction            | is                | Success |
    | 152 | "PIRS Reader"  | tsmetadocaction            | is                | Success |
    | 153 | "system"       | tstosuppliercontrol        | is not            | Success |
    | 154 | "PIRS Admin"   | tstosuppliercontrol        | is not            | Success |
    | 155 | "PIRS Creator" | tstosuppliercontrol        | is                | Success |
    | 156 | "PIRS Reader"  | tstosuppliercontrol        | is                | Success |
    | 157 | "system"       | correspondencecode         | is not            | Success |
    | 158 | "PIRS Admin"   | correspondencecode         | is not            | Success |
    | 159 | "PIRS Creator" | correspondencecode         | is                | Success |
    | 160 | "PIRS Reader"  | correspondencecode         | is                | Success |
    | 161 | "system"       | referencenumbercategory    | is not            | Success |
    | 162 | "PIRS Admin"   | referencenumbercategory    | is not            | Success |
    | 163 | "PIRS Creator" | referencenumbercategory    | is                | Success |
    | 164 | "PIRS Reader"  | referencenumbercategory    | is                | Success |

It would be great if it is possible to define a parameter to perform a grouping, wouldn't it? :)
@janschaefer
Copy link
Contributor

While this might be possible, I am not sure whether this is the best thing to do. What about splitting the scenario in multiple ones? Then you could give each scenario a meaningful name to group the cases.

@nikowitt
Copy link
Contributor Author

The only solution then is to group the scenario by users as the classes are scanned automatically. I'd hoped that I'd be able to not split the dataprovider one more time, but probably you are right and this is the easiest solution.

@nikowitt
Copy link
Contributor Author

Hm, in this particular case, I'd have to split one test into 4 tests and since this a crud test, there would be 16 tests instead of 4 - pretty verbose IMHO.

@janschaefer
Copy link
Contributor

What would be your suggestion?

@nikowitt
Copy link
Contributor Author

Maybe to define an annotation where a field name can be supplied that will be then used for the additional grouping?

@janschaefer
Copy link
Contributor

Ok, but how should the grouping actually look like in the report?

@nikowitt
Copy link
Contributor Author

Good question
Maybe for text, something like (when clazz was selected):

By stripping the redundant content, the large table is much easier to read.


    |   # | userName       | clazz                      | isExceptionThrown | Status  |
    +-----+----------------+----------------------------+-------------------+---------+
    |     |                | customkeyword2             |                   |         |
    |   1 | "system"       |                            | is not            | Success |
    |   2 | "PIRS Admin"   |                            | is not            | Success |
    |   3 | "PIRS Creator" |                            | is                | Success |
    |   4 | "PIRS Reader"  |                            | is                | Success |
    |     |                | customsuperbox3            |                   |         |
    |   5 | "system"       |                            | is not            | Success |
    |   6 | "PIRS Admin"   |                            | is not            | Success |
    |   7 | "PIRS Creator" |                            | is                | Success |
    |   8 | "PIRS Reader"  |                            | is                | Success |
    |     |                | customsuperbox4            |                   |         |
    |   9 | "system"       |                            | is not            | Success |
    |  10 | "PIRS Admin"   |                            | is not            | Success |
    |  11 | "PIRS Creator" |                            | is                | Success |
    |  12 | "PIRS Reader"  |                            | is                | Success |
    |     |                | customkeyword4             |                   |         |
    |  13 | "system"       |                            | is not            | Success |
    |  14 | "PIRS Admin"   |                            | is not            | Success |
    |  15 | "PIRS Creator" |                            | is                | Success |
    |  16 | "PIRS Reader"  |                            | is                | Success |
    |     |                | system                     |                   |         |
    |  17 | "system"       |                            | is not            | Success |
    |  18 | "PIRS Admin"   |                            | is not            | Success |
    |  19 | "PIRS Creator" |                            | is                | Success |
    |  20 | "PIRS Reader"  |                            | is                | Success |
    |     |                | tsfromcustomercontrol      |                   |         |
    |  21 | "system"       |                            | is not            | Success |
    |  22 | "PIRS Admin"   |                            | is not            | Success |
    |  23 | "PIRS Creator" |                            | is                | Success |
    |  24 | "PIRS Reader"  |                            | is                | Success |
    |     |                | customercategory           |                   |         |
    |  25 | "system"       |                            | is not            | Success |
    |  26 | "PIRS Admin"   |                            | is not            | Success |
    |  27 | "PIRS Creator" |                            | is                | Success |
    |  28 | "PIRS Reader"  |                            | is                | Success |
    |     |                | customsuperbox2            |                   |         |
    |  29 | "system"       |                            | is not            | Success |
    |  30 | "PIRS Admin"   |                            | is not            | Success |
    |  31 | "PIRS Creator" |                            | is                | Success |
    |  32 | "PIRS Reader"  |                            | is                | Success |

In the html5 report, the grouping could be collapsible.

@janschaefer janschaefer added this to the v0.10.0 milestone Nov 13, 2015
@janschaefer
Copy link
Contributor

Is it really important for you to have the grouping in the text report? Otherwise this could be just implemented in the HTML report and there would be no need for additional annotations.

@nikowitt
Copy link
Contributor Author

It would be perfectly fine if this is possible in the HTML report.

@janschaefer
Copy link
Contributor

ok, great. That simplifies the solution :-)

janschaefer pushed a commit that referenced this issue Dec 20, 2015
HTML Report: fixed issue with cases table grouping (#168)
8fdb22f
@janschaefer
Copy link
Contributor

I implemented this now in the HTML Report, you can have a look how it looks like here:

http://jgiven.org/snapshot/jgiven-report/html5/#/scenario/com.tngtech.jgiven.impl.ScenarioExecutorTest/step_methods_can_have_primitive_arrays_as_parameters

@nikowitt
Copy link
Contributor Author

Looks really fine to me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement HTML Report
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
2 participants
@nikowitt @janschaefer