-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tags dynamically #172
Comments
What should this look like from a design point of view? Do you want a method which takes a |
I haven't really thought about that. I am not sure whether TagConfiguration is the right thing to use here. The TagConfiguration class is actually used to configure a tag. For applying a tag there should be a more narrow interface. In fact, it should only take the class of the annotation and and optional value, IMO. |
This could be more challenging than I originally anticipated. We need an actual instance of the annotation, not just its class, because we need to pass some instance to the DescriptionGenerator and HrefGenerator if they are being used. However, creating a proper instance of an annotation isn't exactly easy. For example, Hibernate has this proxy class for that problem. There's three obvious (and maybe other, non-obvious) ways out:
|
On a side note, could it be that there's a bug in |
This commit allows adding tags dynamically to a scenario at runtime. Furthermore, it implicitly fixes an issue where nested tags, description and href would not be evaluated if ignoreValue was set to true. fixes TNG#172
This commit allows adding tags dynamically to a scenario at runtime. Furthermore, it implicitly fixes an issue where nested tags, description and href would not be evaluated if ignoreValue was set to true. fixes TNG#172
This commit allows adding tags dynamically to a scenario at runtime. Furthermore, it implicitly fixes an issue where nested tags, description and href would not be evaluated if ignoreValue was set to true. fixes TNG#172
This commit allows adding tags dynamically to a scenario at runtime. Furthermore, it implicitly fixes an issue where nested tags, description and href would not be evaluated if ignoreValue was set to true. fixes TNG#172
This commit allows adding tags dynamically to a scenario at runtime. Furthermore, it implicitly fixes an issue where nested tags, description and href would not be evaluated if ignoreValue was set to true. fixes TNG#172
This commit allows adding tags dynamically to a scenario at runtime. Furthermore, it implicitly fixes an issue where nested tags, description and href would not be evaluated if ignoreValue was set to true. fixes TNG#172
We introduce a new interface CurrentScenario similar to CurrentStep which can be injected into stages. The previously introduced addTag() method is moved from ScenarioBase to this new interface. relates to TNG#172
We introduce a new interface CurrentScenario similar to CurrentStep which can be injected into stages. The previously introduced addTag() method is moved from ScenarioBase to this new interface. relates to TNG#172
We introduce a new interface CurrentScenario similar to CurrentStep which can be injected into stages. The previously introduced addTag() method is moved from ScenarioBase to this new interface. relates to TNG#172
We introduce a new interface CurrentScenario similar to CurrentStep which can be injected into stages. The previously introduced addTag() method is moved from ScenarioBase to this new interface. relates to TNG#172
This commit allows adding tags dynamically to a scenario at runtime. Furthermore, it implicitly fixes an issue where nested tags, description and href would not be evaluated if ignoreValue was set to true. fixes TNG#172
We introduce a new interface CurrentScenario similar to CurrentStep which can be injected into stages. The previously introduced addTag() method is moved from ScenarioBase to this new interface. relates to TNG#172
It might sometimes be useful to add tags dynamically to scenarios
The text was updated successfully, but these errors were encountered: