Use Spring's @Rule support instead of @RunWith(SpringJunit4ClassRunner) #250
Conversation
| @@ -19,10 +16,16 @@ | |||
| * | |||
| * @since 0.8.0 | |||
| */ | |||
| public class SpringScenarioTest<GIVEN, WHEN, THEN> extends | |||
| ScenarioTest<GIVEN, WHEN, THEN> implements BeanFactoryAware { | |||
| public class SpringScenarioTest<GIVEN, WHEN, THEN> extends InternalSpringScenarioTest<GIVEN, WHEN, THEN> { | |||
There was a problem hiding this comment.
I think we need to introduce a new class here, something like RuleBasedSpringScenarioTest. Otherwise users of old Spring versions will not be able to use that class anymore.
|
|
||
| import com.tngtech.jgiven.integration.spring.SpringScenarioTest; | ||
|
|
||
| @RunWith( SpringJUnit4ClassRunner.class ) |
There was a problem hiding this comment.
Same as above: we still need to support the runner-based execution
| * | ||
| * @since 0.14.0 | ||
| */ | ||
| public abstract class InternalSpringScenarioTest<GIVEN, WHEN, THEN> extends ScenarioTestBase<GIVEN, WHEN, THEN> implements BeanFactoryAware { |
There was a problem hiding this comment.
As the constructor is already package-private you could also make the class itself package-private
There was a problem hiding this comment.
No, this does not work because of Springs ClassRule:
org.junit.internal.runners.rules.ValidationError: The @ClassRule 'springClassRule' must be declared in a public class.
Would you think it's more consistent to have the constructor public then?
There was a problem hiding this comment.
And move it to a package named "internal"?
There was a problem hiding this comment.
no I think that would be overkill. The class is visible in any case, so just leave it as it is
| public void setupSpring() { | ||
| wireSteps( new SpringCanWire( beanFactory ) ); | ||
| } | ||
| @ContextConfiguration( classes = TestSpringConfig.class ) |
There was a problem hiding this comment.
good catch, thanks for adapting that!
|
I created new classes as suggested. |
|
Or SimpleSpringRuleScenarioTest and SpringRuleScenarioTest ? |
|
That is even better :-) |
…arting with version 4.2, as an alternative to SpringScenarioTest using SpringJUnit4ClassRunner. Enables the use of custom JUnit runners like DataProviderRunner.
|
Incorporated the changes. |
|
fixes #229 |
Use Spring's @rule support added in v4.2 for the SpringScenarioTest instead of using SpringJUnit4ClassRunner.
Enables the use of custom JUnit runners like DataProviderRunner (see example test).