Feature/configuration file #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-1squared
force-pushed
the
feature/configuration-file
branch
2 times, most recently
from
6947bc7
to
62344c8
Compare
l-1squared
commented
Jul 6, 2021
l-1squared
force-pushed
the
feature/configuration-file
branch
from
30cac38
to
682914f
Compare
l-1squared
commented
Jul 7, 2021
| assertThat(underTest.textReport()).isFalse(); | ||
| assertThat(underTest.textColorEnabled()).isEqualTo(ConfigValue.TRUE); | ||
| assertThat(underTest.filterStackTrace()).isFalse(); | ||
|
|
There was a problem hiding this comment.
unecessary emtpy line
l-1squared
force-pushed
the
feature/configuration-file
branch
2 times, most recently
from
a0bb94e
to
09b4728
Compare
l-1squared
force-pushed
the
feature/configuration-file
branch
from
09b4728
to
a00d378
Compare
l-1squared
commented
Aug 9, 2021
andru47
force-pushed
the
feature/configuration-file
branch
from
a24058a
to
a00d378
Compare
l-1squared
commented
Aug 10, 2021
l-1squared
commented
Aug 10, 2021
jgiven-core/src/test/java/com/tngtech/jgiven/impl/JGivenAppenderImpl.java
Outdated
Show resolved
Hide resolved
andru47
force-pushed
the
feature/configuration-file
branch
from
effc0d6
to
9382958
Compare
fudler
requested changes
Aug 10, 2021
- initial implementation Signed-off-by: Steve Wong <swong@metahq.com>
Signed-off-by: l-1sqared <30831153+l-1squared@users.noreply.github.com>
* Make value holding the properties an instance field * Make constructor private The above measures make the singleton class more aligned with the singleton pattern while also enable unit testing of the config class. Due to the amount of classes in the impl package a private constructor is preferred over a package private one as the latter might be seen as an invitation to just instantiate the class, when this is clearly not desired. Eager reading of the properties file has been deemed acceptable, because the `static` block within the class will ensure that the file is read early anyway. Signed-off-by: l-1sqared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1sqared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1sqared <30831153+l-1squared@users.noreply.github.com>
andru47
force-pushed
the
feature/configuration-file
branch
from
9382958
to
04edbd1
Compare
andru47
force-pushed
the
feature/configuration-file
branch
from
d503abc
to
bbc2e1d
Compare
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
andru47
force-pushed
the
feature/configuration-file
branch
from
bbc2e1d
to
bbaf5c6
Compare
Signed-off-by: Andru Stefanescu <als209@cam.ac.uk>
fudler
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.