Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/instruction bar #20

Merged
merged 5 commits into from
Dec 3, 2022
Merged

Feature/instruction bar #20

merged 5 commits into from
Dec 3, 2022

Conversation

TNorbury
Copy link
Owner

@TNorbury TNorbury commented Dec 3, 2022

closes #14

Adds a flag, showInstructions, to CommandPaletteConfig. Setting to true will show an instruction bar like so:
image

When a nested item is selected, an additional instruction will be added:
image

This PR also includes the exporting of a new widget KeyboardKeyIcon, which is used to make the Keyboard Keys used in this package (such as for the trailing widget for action, or in the instruction bar itself). This will allow users to mimic the keyboard shortcut widget used in the default action builder.

example/lib/main.dart Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Merging #20 (d3dce24) into development (f883168) will increase coverage by 3.70%.
The diff coverage is 99.05%.

@@               Coverage Diff               @@
##           development      #20      +/-   ##
===============================================
+ Coverage        93.02%   96.72%   +3.70%     
===============================================
  Files                7        9       +2     
  Lines              430      489      +59     
===============================================
+ Hits               400      473      +73     
+ Misses              30       16      -14     
Impacted Files Coverage Δ
lib/src/widgets/command_palette_modal.dart 96.61% <ø> (ø)
lib/src/widgets/options/command_palette_body.dart 97.10% <97.36%> (ø)
lib/src/command_palette.dart 93.10% <100.00%> (+11.52%) ⬆️
lib/src/widgets/command_palette_instructions.dart 100.00% <100.00%> (ø)
lib/src/widgets/keyboard_key_icon.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TNorbury TNorbury linked an issue Dec 3, 2022 that may be closed by this pull request
@TNorbury TNorbury merged commit d377a2b into development Dec 3, 2022
@TNorbury TNorbury deleted the feature/instruction_bar branch December 3, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instruction bar
2 participants