Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add barrierFilter to CP Style to set the filter being used by the Mod… #27

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

TNorbury
Copy link
Owner

closes #25

Adds a barrierFilter to CommandPaletteStyle to set the ImageFilter that will go behind the command palette when it's open.

Luckily ModalRoute, which is what wraps around the command palette when it's open, has an argument filter in its constructor, so this ended up being a super simple change 🥂

@TNorbury TNorbury added this to the 0.6.1 milestone Dec 15, 2022
@TNorbury TNorbury linked an issue Dec 15, 2022 that may be closed by this pull request
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/models/command_palette_style.dart Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #27 (007defe) into development (b3e5e7f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development      #27      +/-   ##
===============================================
+ Coverage        96.82%   96.84%   +0.01%     
===============================================
  Files                9        9              
  Lines              504      507       +3     
===============================================
+ Hits               488      491       +3     
  Misses              16       16              
Impacted Files Coverage Δ
lib/src/command_palette.dart 93.38% <100.00%> (+0.11%) ⬆️
lib/src/widgets/command_palette_modal.dart 97.18% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

spelling fixes of a sleepy dude
@TNorbury TNorbury merged commit ec53a31 into development Dec 15, 2022
@TNorbury TNorbury deleted the enhancement/background_blur branch December 15, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add option to blur background behind modal
2 participants