Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement input action #35

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Implement input action #35

merged 2 commits into from
Oct 30, 2023

Conversation

NishiyamaPedro
Copy link
Contributor

No description provided.

@NishiyamaPedro NishiyamaPedro marked this pull request as draft June 26, 2023 04:40
@NishiyamaPedro NishiyamaPedro marked this pull request as ready for review June 26, 2023 16:34
@TNorbury
Copy link
Owner

Thank you for this pull request, and I apologize that I'm just now seeing it. I will try to take a look at it in the coming weeks.

Would you be able to add one of these types of actions to the example (see here). That way I can have an idea of how it's supposed to be used.

Thanks!

@TNorbury TNorbury linked an issue Sep 29, 2023 that may be closed by this pull request
Feature Request: Allow entered text as parameter for a callback. #32
Closed
TNorbury
TNorbury requested changes Sep 29, 2023
View reviewed changes
Copy link
Owner

@TNorbury TNorbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this PR. It looks really great, just a few housekeeping items, in addition to what I mentioned above.

lib/src/controller/command_palette_controller.dart Outdated Show resolved Hide resolved
lib/src/models/command_palette_action.dart Show resolved Hide resolved
@TNorbury TNorbury changed the base branch from main to development September 29, 2023 14:58
@NishiyamaPedro
Copy link
Contributor Author

Thanks for the review. I've made the requested changes and added a basic example.

@TNorbury TNorbury merged commit 655839e into TNorbury:development Oct 30, 2023
@TNorbury
Copy link
Owner

Awesome, thanks for the changes!

@TNorbury TNorbury mentioned this pull request Oct 30, 2023
Closed
TNorbury added a commit that referenced this pull request Oct 30, 2023
@TNorbury
changelog for PR #35
2031a4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TNorbury TNorbury Awaiting requested review from TNorbury

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow entered text as parameter for a callback.
2 participants
@NishiyamaPedro @TNorbury