fix ids (cvat-ai#10)

TOsmanov · Sep 10, 2020 · fd67751 · fd67751
1 parent 2756d7f
commit fd67751
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/datumaro/plugins/coco_format/converter.py b/datumaro/plugins/coco_format/converter.py
@@ -85,7 +85,7 @@ def save_annotations(self, item):
     def write(self, path):
         next_id = self._min_ann_id
         for ann in self.annotations:
-            if ann['id'] is None:
+            if not ann['id']:
                 ann['id'] = next_id
                 next_id += 1
 

diff --git a/tests/test_coco_format.py b/tests/test_coco_format.py
@@ -477,3 +477,21 @@ def test_annotation_attributes(self):
         with TestDir() as test_dir:
             self._test_save_and_load(expected_dataset,
                 CocoConverter.convert, test_dir)
+
+    def test_auto_annotation_ids(self):
+        source_dataset = Dataset.from_iterable([
+            DatasetItem(id=2, image=np.ones((4, 2, 3)), annotations=[
+                Polygon([0, 0, 4, 0, 4, 4], label=0),
+            ])
+        ], categories=[str(i) for i in range(10)])
+
+        target_dataset = Dataset.from_iterable([
+            DatasetItem(id=2, image=np.ones((4, 2, 3)), annotations=[
+                Polygon([0, 0, 4, 0, 4, 4], label=0, id=1, group=1,
+                    attributes={'is_crowd': False}),
+            ], attributes={'id': 1})
+        ], categories=[str(i) for i in range(10)])
+
+        with TestDir() as test_dir:
+            self._test_save_and_load(source_dataset,
+                CocoConverter.convert, test_dir, target_dataset=target_dataset)