Facilitate better backtraces in CI #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dylan Simon <dylan@dylex.net> Co-authored-by: Alexander Hampel <ahampel@flatironinstitute.org>
hmenke
commented
Oct 6, 2023
| @@ -96,6 +97,8 @@ jobs: | |||
| - name: Test app4triqs | |||
| env: | |||
| DYLD_FALLBACK_LIBRARY_PATH: /usr/local/opt/llvm/lib | |||
| LD_PRELOAD: /usr/lib/x86_64-linux-gnu/libSegFault.so | |||
There was a problem hiding this comment.
Using libSegFault is debatable.
There was a problem hiding this comment.
Would this have any implications in the absence of segfaults?
There was a problem hiding this comment.
Essentially the entire constructor boils down to sigaction (SIGSEGV, &sa, NULL); where sa is the custom segfault handler. So in the absence of SIGSEGV this will still consume one additional slot on the signal stack and might clash or otherwise interact with other signal handlers, although I don't think that TRIQS uses POSIX signals for anything.
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: Henri Menke <henri@henrimenke.de>
This still includes optimizations. Roughly corresponds to "-O2 -g -DNDEBUG" https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/Compiler/GNU.cmake
Unfortunately there is no upstream documentation, so here are two blogposts. https://www.marcusfolkesson.se/blog/libsegfault/ https://lemire.me/blog/2023/05/01/under-linux-libsegfault-and-addr2line-are-underrated/
|
I've split the PR into multiple commits, so you can cherry-pick what you consider reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.