-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facilitate better backtraces in CI #12
Conversation
Co-authored-by: Dylan Simon <dylan@dylex.net> Co-authored-by: Alexander Hampel <ahampel@flatironinstitute.org>
@@ -96,6 +97,8 @@ jobs: | |||
- name: Test app4triqs | |||
env: | |||
DYLD_FALLBACK_LIBRARY_PATH: /usr/local/opt/llvm/lib | |||
LD_PRELOAD: /usr/lib/x86_64-linux-gnu/libSegFault.so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using libSegFault
is debatable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this have any implications in the absence of segfaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially the entire constructor boils down to sigaction (SIGSEGV, &sa, NULL);
where sa
is the custom segfault handler. So in the absence of SIGSEGV
this will still consume one additional slot on the signal stack and might clash or otherwise interact with other signal handlers, although I don't think that TRIQS uses POSIX signals for anything.
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: Henri Menke <henri@henrimenke.de>
This still includes optimizations. Roughly corresponds to "-O2 -g -DNDEBUG" https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/Compiler/GNU.cmake
Unfortunately there is no upstream documentation, so here are two blogposts. https://www.marcusfolkesson.se/blog/libsegfault/ https://lemire.me/blog/2023/05/01/under-linux-libsegfault-and-addr2line-are-underrated/
I've split the PR into multiple commits, so you can cherry-pick what you consider reasonable. |
No description provided.