-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MPI routines more restrictive and improve their docs #74
Open
Thoemi09
wants to merge
7
commits into
TRIQS:unstable
Choose a base branch
from
Thoemi09:DEV_MPI
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wentzell
force-pushed
the
unstable
branch
8 times, most recently
from
July 30, 2024 16:18
2cdbb07
to
eac10ed
Compare
Thank you @Thoemi09 for these changes, can you split the doc changes the source code changes for easier review? |
Sure, I can do that |
Thoemi09
force-pushed
the
DEV_MPI
branch
7 times, most recently
from
September 30, 2024 22:21
f3772cd
to
10d8873
Compare
- simplify by using the range functions from mpi
- change the type stored in the lazy object - change the shape of the resulting ArrayInitializer object - make the checks more consistent - simplify by using the range functions from mpi
- change the type stored in the lazy object - change the shape of the resulting ArrayInitializer object - make the checks more consistent - simplify by using the range functions from mpi
- change the type stored in the lazy object - make the checks more consistent - restrict to C order arrays/views - simplify by using the range functions from mpi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the MPI routines by making the requirements more restrictive and add some more checks.