Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our discussion on Slack. Includes a test that was failing (now passing).
To hunt this down I basically started implementing SHA1 on my own, and then lined it up with your code (which, btw, is way more straightforward than other implementations out there, esp. JS ones). I couldn't figure out the zero padding calculation:
64 - modBy 64 (List.length bytes + 1 + 8)
, so I just replaced it with the formula I had ended up with:modBy 64 (56 - modBy 64 (byteCount + 1))
and all the tests passed! More verbosely, this calculation is:elm-test