Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressed performance warning for many small chunks in reorder(...) #79

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

vanlankveldthijs
Copy link
Contributor

Resolves #73

  • Suppressed all warnings while calling xarray.sortby in stm.reorder.
  • Added a note that only PerformanceWarning should be suppressed, but the type could not be properly determined.
  • Indicated in reorder function description that this can be a costly operation.

Copy link
Member

@rogerkuou rogerkuou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @vanlankveldthijs! Please go ahead and merge this.

@rogerkuou rogerkuou merged commit 2475621 into main Jun 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance warning in re-order
2 participants