Study Cards #495

sebmarste · 2017-07-18T21:20:04Z

first implementation of the study card feature (demo)
Issue #457

- card list - adding cards

kordianbruck · 2017-07-18T21:23:45Z

app/build.gradle

@@ -42,6 +43,9 @@ android {
        exclude 'META-INF/maven/com.google.guava/guava/pom.xml'
    }

+    dataBinding {
+        enabled = true


I didn't know about this stuff - cool! 👍

kordianbruck · 2017-07-18T21:24:21Z

app/src/main/java/de/tum/in/tumcampusapp/activities/CardsDetailActivity.java

+import de.tum.in.tumcampusapp.models.tumcabe.ChatMember;
+import de.tum.in.tumcampusapp.models.tumcabe.ChatVerification;
+
+public class CardsDetailActivity extends AppCompatActivity {


Please extend our Generic Classes - do not directly use the AppCompat stuff.

kordianbruck · 2017-07-18T21:25:12Z

app/src/main/java/de/tum/in/tumcampusapp/activities/CardsDetailActivity.java

+    }
+
+    private boolean save() {
+        if (card.is_valid()) {


Invert these ifs please. e.g.:
if (!card.is_valid()) { return false; }

kordianbruck · 2017-07-18T21:25:41Z

app/src/main/java/de/tum/in/tumcampusapp/activities/generic/ActivityForLoadingInBackground.java

@@ -38,6 +38,8 @@ public ActivityForLoadingInBackground(int layoutId) {
 		super(layoutId);
 	}

+	public ActivityForLoadingInBackground() { super(); }


Why do we need this?

refactored all this (using overwriting the setUpLayout method)

kordianbruck · 2017-07-18T21:26:09Z

app/src/main/java/de/tum/in/tumcampusapp/activities/generic/BaseActivity.java

@@ -50,12 +50,21 @@ public BaseActivity(int layoutId) {
        mLayoutId = layoutId;
    }

+    public BaseActivity() { mLayoutId = null;}


ehhhm ??? Please explain.

kordianbruck · 2017-07-18T21:27:02Z

app/src/main/java/de/tum/in/tumcampusapp/activities/generic/ProgressActivity.java

@@ -51,10 +51,18 @@ public ProgressActivity(int layoutId) {
        super(layoutId);
    }

+    public ProgressActivity() { super(); }


kordianbruck · 2017-07-18T21:27:26Z

app/src/main/java/de/tum/in/tumcampusapp/activities/generic/ProgressActivity.java

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

+        if (this.mLayoutId != null) {


This shouldn't be allowed to be null in the first place - thats why we don't have any default constructors.

removed (this was to inflate the layout with data binding)

kordianbruck · 2017-07-18T21:28:11Z

app/src/main/java/de/tum/in/tumcampusapp/models/cards/StudyCard.java

+public class StudyCard extends BaseObservable {
+
+    private int id;
+    //private ChatMember member;


Commented code should not be in git.

kordianbruck · 2017-07-18T21:28:41Z

app/src/main/java/de/tum/in/tumcampusapp/widgets/MVVWidget.java

@@ -127,6 +127,7 @@ static void updateAppWidgets(Context context, AppWidgetManager appWidgetManager,
    static void updateAppWidget(Context context, AppWidgetManager appWidgetManager,
                                int appWidgetId, boolean forceLoadData) {
        // Get the settings for this widget from the database
+        if (transportManager == null) transportManager = new TransportManager(context);


Bug fix? Please put this in a separate PR.

kordianbruck · 2017-07-18T21:29:07Z

build.gradle

@@ -18,10 +18,11 @@ allprojects {
        options.fork = true  // Fork your compilation into a child process
        options.forkOptions.setMemoryMaximumSize("4g") // Set maximum memory to 4g
        options.compilerArgs << "-Xlint:all"
-        options.compilerArgs << "-Werror"
+        // options.compilerArgs << "-Werror"


Never touch this file. @pfent will be very angry...

the problem here is, that i get warnings (i assume caused by the data binding library) and with this flag set it will not compile with warnings... ill investigate this after the presentation

@pfent is there not some config file to add exceptions for those libs? I remember seeing it somewhere but not exactly...

Usually, you can always @SuppressWarnings of the specific thing that errors.
Please don't disable the -Werror, it really helps to keep developers to think about their code ❤️

@pfend, @kordianbruck: These are the actual warnings I get:

Warning:No processor claimed any of these annotations: java.lang.SafeVarargs,android.databinding.BindingBuildInfo,org.simpleframework.xml.ElementList,android.support.annotation.NonNull,com.google.gson.annotations.SerializedName,org.simpleframework.xml.Root,retrofit2.http.PUT,android.annotation.SuppressLint,retrofit2.http.DELETE,retrofit2.http.GET,retrofit2.http.Path,org.simpleframework.xml.Text,android.support.annotation.Nullable,retrofit2.http.POST,retrofit2.http.Body,org.simpleframework.xml.Element,android.annotation.TargetApi,android.databinding.Bindable /Users/sebastianstein/Google Drive/Uni/android praktikum/TumCampusApp/app/build/generated/source/apt/debug/de/tum/in/tumcampusapp/databinding/ActivityCardsQuizBinding.java Warning:(59, 37) [cast] redundant cast to String Warning:(85, 36) [cast] redundant cast to String Warning:(180, 112) [unchecked] unchecked cast required: ObservableField<Boolean> found: Object /Users/sebastianstein/Google Drive/Uni/android praktikum/TumCampusApp/app/build/generated/source/apt/debug/de/tum/in/tumcampusapp/databinding/ActivityCardsDetailBinding.java Warning:(52, 32) [cast] redundant cast to String Warning:(78, 37) [cast] redundant cast to String Warning:(104, 36) [cast] redundant cast to String

The first one appears since i enabled databinding for the project.
The others are cast warnings in the Binding Classes which are generated by the databinding library.
So I cant simply fix the cast problems there or add the @SuppressWarnings annotation.

But I totally understand why this flag is set and i am going to investigate on this after the "hot time" of the praktikum.

I think I remember correctly, you can exculde this with proguard:
https://github.com/krschultz/android-proguard-snippets/tree/master/libraries
https://github.com/TCA-Team/TumCampusApp/blob/master/proguard/proguard-project-rules.pro

using the -dontwarn flag

kordianbruck · 2018-02-21T13:04:00Z

I think we should merge this for now and finish work on this in the coming semester.

…57-study-cards # Conflicts: # app/build.gradle # app/src/main/java/de/tum/in/tumcampusapp/api/TUMCabeClient.java # app/src/main/java/de/tum/in/tumcampusapp/auxiliary/DrawerMenuHelper.java # app/src/main/res/values-de/strings.xml # app/src/main/res/values/strings.xml # app/src/main/res/xml/settings.xml # build.gradle

pfent · 2018-02-21T13:38:09Z

app/build.gradle

@@ -107,7 +107,7 @@ dependencies {
    annotationProcessor "android.arch.lifecycle:compiler:$roomVersion"
    annotationProcessor "android.arch.persistence.room:compiler:$roomVersion"
    implementation "com.google.android.gms:play-services-location:$firebaseVersion"
-    implementation 'com.android.support.constraint:constraint-layout:1.0.2'
+    implementation 'com.android.support.constraint:constraint-layout:1.0.2'openinghours


no, please don't

added first implementation for:

7dbb637

- card list - adding cards

sebmarste added Not Ready Work in progress labels Jul 18, 2017

sebmarste self-assigned this Jul 18, 2017

sebmarste requested a review from kordianbruck July 18, 2017 21:20

kordianbruck suggested changes Jul 18, 2017

View reviewed changes

sebastianstein and others added 3 commits July 19, 2017 13:12

reworked generic activity classes for data binding

3dd81ce

added first study card quiz implementation

17f6a64

Merge branch 'master' into sebmarste/457-study-cards

802a6d1

kordianbruck removed the Not Ready label Oct 16, 2017

kordianbruck approved these changes Feb 21, 2018

View reviewed changes

kordianbruck added 4 commits February 21, 2018 14:24

Cleanup merge

92aece0

Cleanup merge

2342a9a

Cleanup merge

cdbeff6

kordianbruck merged commit 3fa455c into master Feb 21, 2018

kordianbruck deleted the sebmarste/457-study-cards branch February 21, 2018 13:37

pfent reviewed Feb 21, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Study Cards #495

Study Cards #495

sebmarste commented Jul 18, 2017 •

edited by kordianbruck

Loading

kordianbruck Jul 18, 2017

kordianbruck Jul 18, 2017

sebmarste Jul 19, 2017

kordianbruck Jul 18, 2017

sebmarste Jul 19, 2017

kordianbruck Jul 18, 2017

sebmarste Jul 19, 2017

kordianbruck Jul 18, 2017

sebmarste Jul 19, 2017

kordianbruck Jul 18, 2017

sebmarste Jul 19, 2017

kordianbruck Jul 18, 2017

sebmarste Jul 19, 2017

kordianbruck Jul 18, 2017

sebmarste Jul 20, 2017

kordianbruck Jul 18, 2017

kordianbruck Jul 18, 2017

sebmarste Jul 19, 2017

kordianbruck Jul 19, 2017

pfent Jul 20, 2017

sebmarste Jul 20, 2017 •

edited

Loading

kordianbruck Jul 20, 2017

kordianbruck commented Feb 21, 2018

pfent Feb 21, 2018

kordianbruck Feb 21, 2018

Study Cards #495

Study Cards #495

Conversation

sebmarste commented Jul 18, 2017 • edited by kordianbruck Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebmarste Jul 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kordianbruck commented Feb 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sebmarste commented Jul 18, 2017 •

edited by kordianbruck

Loading

sebmarste Jul 20, 2017 •

edited

Loading