This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The Panel had a couple of issues:
This fixes the following issue(s):
In order to fix these issues, I decided to redesign the hole Panel. First, instead of changing its position, now the panel is attached to the bottom (i.e. the TabBar) and by dragging the Panel the user changes its height. By changing this all Mensas/Study Rooms are now visible and the panel could never be dragged above the TabBar.
Screenshots
Issues
First Issue:
Simulator.Screen.Recording.-.iPhone.12.-.2022-07-22.at.08.47.42.mp4
Second Issue:
RPReplay_Final1658472764.MOV
See that the Panel is postion adjusted
Now the solution:
IMPORTANT NOTE:
Due to a suspected SwiftUI bug with the drag gesture to adjust the height and the scrolling of the ScrollView, I decided to add another
Rectangle()
which has the.gesture()
attached instead of thePanelContentView()
See the suspected SwiftUI bug in another DemoApp:
180417073-f2ceaf1d-fbb1-4634-a579-ef457b229e72.mov
Project files of DemoApp:
DragGestureScrollView.zip
See the
Rectangle()
which is stacked on top of thePanel
and will be moved in sycn with thePanel
so stick to the top of the panel and has aSpacer()
(panelHeight-dragAreaHeight) underneath it.