Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cal-4] Calendar microservice #357

Merged
merged 4 commits into from
Jan 23, 2023
Merged

[Cal-4] Calendar microservice #357

merged 4 commits into from
Jan 23, 2023

Conversation

CommanderStorm
Copy link
Member

@CommanderStorm CommanderStorm commented Jan 18, 2023

This is one PR in the calendar PR-Train (#221)

Proposed Changes

  • This PR migrates the calendar API into its Microservice
  • The core reasoning behind this is simple:
    • Whenever we redeploy the server, we lose the calendar data
    • Reacquiring this data takes a long time
    • Migrating this into its microservice makes sense, as I can then only redeploy if really needed

How to test this PR

  1. Honestly, there is no critical part that needs reviewing, as this is just a code-move

How has this been tested?

  • see if it compiles ;)
  • test if the core APIs (search/details) still work

Checklist:

  • I have updated the documentation / No need to update the documentation
  • I have run the linter

@CommanderStorm CommanderStorm requested a review from octycs January 18, 2023 00:31
@CommanderStorm CommanderStorm self-assigned this Jan 18, 2023
@CommanderStorm CommanderStorm merged commit ba85d90 into main Jan 23, 2023
@CommanderStorm CommanderStorm deleted the calendar-microservice branch January 23, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant