Enh/add runner workflow #1390
Enh/add runner workflow #1390
Conversation
|
Your Testserver will be ready at https://1390.test.live.mm.rbg.tum.de in a few minutes. Logins
|
SebiWrn
requested review from
CommanderStorm,
joschahenningsen,
karjo24 and
DawinYurtseven
| - uses: actions/checkout@v3 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} |
There was a problem hiding this comment.
- Let's use
checkout@v4and - add a comment wat this ref is for (I'd assume this or something equivalent should be the default, right?)
| id: vars | ||
| run: echo "::set-output name=sha_short::$(git rev-parse --short HEAD)" | ||
| - name: Build and push Docker images (${{ matrix.module }}) | ||
| uses: docker/build-push-action@v4 |
There was a problem hiding this comment.
You might want to configure sbom and build provence here.
Example how I did this:
https://github.com/TUM-Dev/NavigaTUM/blob/main/.github/workflows/_docker-build.yml
(This does not have an immediate impact but allows more forensics for some attack scenarios for little to no maintenance-effort as far as I read up on)
| push: true | ||
| build-args: version=${{ github.ref_name }} | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} |
There was a problem hiding this comment.
You might want to configure cache-from and related parameters.
Here is an example how to do this: https://docs.docker.com/build/ci/github-actions/cache/#cache-mounts
Likely the builds are already really fast (looking at you, rust), but a few seconds for a few lines...
|
Thank you for the feedback, I think I'll deploy it anyway so we can deploy the beta system as fast as possible, but I'll keep your feedback in mind and open another PR for these changes so I can also change this on the current workers and tumlive deployment actions. |
Adds a new workflow the the github workflows so runners from the beta branch can be deployed