Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect target for user notifications #1397

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

carlobortolan
Copy link
Member

Motivation and Context

See issue #1298.

Description

Included target field to notification model's JSON.

Steps for Testing

Prerequisites:

  • 1 admin, 1 student
  • Optionally also 1 lecturer or loggedIn user
  1. Log in as an admin
  2. Open the notifications panel (http://localhost:8081/admin/notifications) and create a few new notifications with a specific target
  3. Log out and log in again using a different user to see the correct notifications (e.g., now a student-user should only see notifications with targets: Students and All Users)

Screenshots

@carlobortolan carlobortolan added the bug Something isn't working label Nov 4, 2024
@carlobortolan carlobortolan marked this pull request as ready for review November 4, 2024 16:11
Copy link

github-actions bot commented Nov 4, 2024

Your Testserver will be ready at https://1397.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@carlobortolan carlobortolan self-assigned this Nov 4, 2024
@carlobortolan carlobortolan merged commit 675eb86 into dev Nov 5, 2024
9 checks passed
@carlobortolan carlobortolan deleted the 1298-target-not-correct-for-user-notifications branch November 5, 2024 10:38
@carlobortolan carlobortolan linked an issue Nov 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target not correct for user notifications
2 participants