Add option for custom reading method name to adapters #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default function name in the validation framework
s-scherrer
requested changes
Jul 29, 2021
s-scherrer
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes here (also in C files) are due to applying pre-commit hooks.
The 2 relevant parts are
read/read_tsto the adapters. Data from this method (which is expected to return a DataFrame) is modified in the same way as for read/read_ts. By default, nothing changes compared to the previous implementation.read_tsfunction withread, asread_tsis deprecated in pygeobase and leads to many warnings when used in the validation framework.