[TASK] Migrate IndexQueue + Garbage Collector Fixtures to CSV

Tests/Integration/Domain/Index/IndexServiceTest.php

@@ -16,18 +16,12 @@
 namespace ApacheSolrForTypo3\Solr\Tests\Integration\Domain\Index;
 
 use ApacheSolrForTypo3\Solr\Domain\Index\IndexService;
-use ApacheSolrForTypo3\Solr\Domain\Site\Exception\UnexpectedTYPO3SiteInitializationException;
 use ApacheSolrForTypo3\Solr\Domain\Site\SiteRepository;
 use ApacheSolrForTypo3\Solr\IndexQueue\Queue;
 use ApacheSolrForTypo3\Solr\System\Environment\CliEnvironment;
-use ApacheSolrForTypo3\Solr\System\Environment\WebRootAllReadyDefinedException;
 use ApacheSolrForTypo3\Solr\Tests\Integration\IntegrationTest;
-use Doctrine\DBAL\ConnectionException;
-use Doctrine\DBAL\Exception as DoctrineDBALException;
-use TYPO3\CMS\Core\Cache\Exception\NoSuchCacheException;
 use TYPO3\CMS\Core\Core\Environment;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\TestingFramework\Core\Exception as TestingFrameworkCoreException;
 
 /**
  * Testcase for the record indexer
@@ -49,10 +43,6 @@ class IndexServiceTest extends IntegrationTest
 
     protected ?Queue $indexQueue = null;
 
-    /**
-     * @throws NoSuchCacheException
-     * @throws TestingFrameworkCoreException
-     */
     protected function setUp(): void
     {
         parent::setUp();
@@ -61,10 +51,6 @@ protected function setUp(): void
         $this->indexQueue = GeneralUtility::makeInstance(Queue::class);
     }
 
-    /**
-     * @throws DoctrineDBALException
-     * @throws UnexpectedTYPO3SiteInitializationException
-     */
     protected function addToIndexQueue(string $table, int $uid): void
     {
         // write an index queue item
@@ -83,17 +69,6 @@ public function canResolveBaseAsPrefixDataProvider(): array
 
     /**
      * @dataProvider canResolveBaseAsPrefixDataProvider
-     *
-     * @param string $absRefPrefix
-     * @param string $expectedUrl
-     *
-     *
-     * @throws ConnectionException
-     * @throws DoctrineDBALException
-     * @throws TestingFrameworkCoreException
-     * @throws UnexpectedTYPO3SiteInitializationException
-     * @throws WebRootAllReadyDefinedException
-     *
      * @test
      */
     public function canResolveBaseAsPrefix(string $absRefPrefix, string $expectedUrl)

Tests/Integration/Domain/Search/ResultSet/Fixtures/fe_user_page.csv

@@ -1,14 +1,14 @@
 "pages",
 ,"uid","pid","is_siteroot","doktype","slug","title","fe_group","module"
-,2,1,0,1,"/public","Public page",0,""
+,2,1,0,1,"/public","Public page",,""
 ,3,1,0,1,"/restricted","Private page",1,""
-,4,1,0,254,"/folder","FE Users",0,"fe_users"
+,4,1,0,254,"/folder","FE Users",,"fe_users"
 "tt_content",
 ,"uid","pid","colPos","CType","bodytext"
 ,1,3,0,"text","Top secret content"
 "fe_groups",
 ,"uid","pid","title"
 ,1,4,"Secret"
 "fe_users",
-,"uid","pid","username","usergroup"
-,1,4,"test",1
+,"uid","pid","username","password","usergroup"
+,1,4,"test","blablabla","1"

Tests/Integration/Domain/Search/ResultSet/ResultSetReconstitutionProcessorTest.php

@@ -15,7 +15,6 @@
 
 namespace ApacheSolrForTypo3\Solr\Tests\Integration\Domain\Search\ResultSet;
 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\InvalidFacetPackageException;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Options\Option;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Options\OptionsFacet;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\ResultSetReconstitutionProcessor;
@@ -25,21 +24,11 @@
 use ApacheSolrForTypo3\Solr\System\Solr\ResponseAdapter;
 use ApacheSolrForTypo3\Solr\Tests\Integration\IntegrationTest;
 use PHPUnit\Framework\MockObject\MockObject;
-use TYPO3\CMS\Core\Error\Http\InternalServerErrorException;
-use TYPO3\CMS\Core\Error\Http\ServiceUnavailableException;
-use TYPO3\CMS\Core\Exception\SiteNotFoundException;
-use TYPO3\TestingFramework\Core\Exception as TestingFrameworkCoreException;
 
 class ResultSetReconstitutionProcessorTest extends IntegrationTest
 {
     /**
      * @test
-     *
-     * @throws InternalServerErrorException
-     * @throws ServiceUnavailableException
-     * @throws SiteNotFoundException
-     * @throws TestingFrameworkCoreException
-     * @throws InvalidFacetPackageException
      */
     public function canApplyRenderingInstructionsOnOptions()
     {
@@ -90,12 +79,6 @@ public function canApplyRenderingInstructionsOnOptions()
 
     /**
      * @test
-     *
-     * @throws InternalServerErrorException
-     * @throws InvalidFacetPackageException
-     * @throws ServiceUnavailableException
-     * @throws SiteNotFoundException
-     * @throws TestingFrameworkCoreException
      */
     public function labelCanBeUsedAsCObject()
     {
@@ -129,10 +112,6 @@ public function labelCanBeUsedAsCObject()
         self::assertSame('MY TYPE WITH SPECIAL RENDERING', $facet->getLabel(), 'Rendering instructions have not been applied on the facet options');
     }
 
-    /**
-     * @param string $fixtureFile
-     * @return SearchResultSet
-     */
     protected function initializeSearchResultSetFromFakeResponse(string $fixtureFile): SearchResultSet
     {
         $searchRequestMock = $this->createMock(SearchRequest::class);
@@ -147,22 +126,13 @@ protected function initializeSearchResultSetFromFakeResponse(string $fixtureFile
         return $searchResultSet;
     }
 
-    /**
-     * @param array $facetConfiguration
-     * @return array
-     */
     protected function getConfigurationArrayFromFacetConfigurationArray(array $facetConfiguration): array
     {
         $configuration = [];
         $configuration['plugin.']['tx_solr.']['search.']['faceting.'] = $facetConfiguration;
         return $configuration;
     }
 
-    /**
-     * @param array $configuration
-     * @param SearchResultSet $searchResultSet
-     * @return ResultSetReconstitutionProcessor
-     */
     protected function getConfiguredReconstitutionProcessor(array $configuration, SearchResultSet $searchResultSet): ResultSetReconstitutionProcessor
     {
         $typoScriptConfiguration = new TypoScriptConfiguration($configuration);

Tests/Integration/Fixtures/can_remove_page.csv

@@ -0,0 +1,11 @@
+"pages",
+,"uid","pid","is_siteroot","doktype","hidden","slug","title"
+,2,1,0,1,0,"/test-childpage","Test Childpage"
+"tt_content",
+,"uid","pid","colPos","CType","bodytext"
+,88,2,0,"text","will be removed!"
+,99,1,0,"text","will stay!"
+"tx_solr_indexqueue_item",
+,"uid","root","item_type","item_uid","indexing_configuration","errors","indexed","changed"
+,4711,1,"pages",1,"pages","",1,1449151778
+,4712,1,"pages",2,"pages","",1,1449151778