[TASK] Evaluate all entries in Services.yaml regarding to shared se…

…tting

All entries in Services.yaml become the `shared` setting dependent on its implementation and context.
All non-Singleton-Like classes are set to `shared: false` which could stuck with objects states:
* on Builder-Objects
* on Query-Objects
* on other object, those state change is not global relevant
Some classes were commented with todos.

Relates: #3995
Fixes: #4183, #4246

Classes/EventListener/Extbase/PersistenceEventListener.php

@@ -43,7 +43,7 @@ public function entityPersisted(EntityPersistedEvent $event): void
         $object = $event->getObject();
         $tableName = $this->getTableName($object);
         if (!$this->skipMonitoringOfTable($tableName)) {
-            // Entity might turn inaccessable
+            // Entity might turn inaccessible
             $this->eventDispatcher->dispatch(new RecordGarbageCheckEvent($object->getUid(), $tableName));
             // Entity added/updated
             $this->eventDispatcher->dispatch(new RecordUpdatedEvent($object->getUid(), $tableName));

Classes/Search/FacetingComponent.php

@@ -33,6 +33,8 @@
 
 /**
  * Modifies a query to add faceting parameters
+ *
+ * @todo: Check the implementation can handle results properly if multiple plugins inserted to page.
  */
 class FacetingComponent implements LoggerAwareInterface
 {

Classes/Search/LastSearchesComponent.php

@@ -24,6 +24,8 @@
 
 /**
  * Writes the last searches
+ * @todo: Neither the table `tx_solr_last_searches` know about pluginNamespaces/PID nor the component is covered with caching.
+ *        So either make the last searches component distinguishable for PID+pluginNamespaces, or enable caching for that, to avoid to restore same data from DB.
  */
 class LastSearchesComponent
 {

Classes/Search/StatisticsComponent.php

@@ -24,6 +24,9 @@
 
 /**
  * Statistics search component
+ *
+ * @todo: Neither the table `tx_solr_statistics` know about pluginNamespaces nor the component is covered with caching.
+ *         So either make the statistics component distinguishable for pluginNamespaces, or enable caching, to avoid to restore same data from DB.
  */
 class StatisticsComponent
 {

Configuration/Services.yaml

@@ -30,6 +30,7 @@ services:
     resource: '../Classes/ViewHelpers/*'
     public: true
     autowire: true
+    shared: false
 
   backend_controller:
     namespace: ApacheSolrForTypo3\Solr\Controller\Backend\Search\
@@ -41,14 +42,17 @@ services:
   ApacheSolrForTypo3\Solr\Domain\Search\ApacheSolrDocument\Builder:
     public: true
     autowire: true
+    shared: false
 
   ApacheSolrForTypo3\Solr\Domain\Search\Uri\SearchUriBuilder:
     public: true
     autowire: true
+    shared: false
 
   ApacheSolrForTypo3\Solr\Domain\Variants\IdBuilder:
     public: true
     autowire: true
+    shared: false
 
   # BE modules, plugins
   ApacheSolrForTypo3\Solr\Backend\SettingsPreviewOnPlugins:
@@ -58,16 +62,19 @@ services:
       - name: event.listener
         identifier: 'solr.plugin.be.settings.preview'
         event: TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent
+    shared: false
   # END: BE modules
 
   viewhelpers_backend:
     namespace: ApacheSolrForTypo3\Solr\ViewHelpers\Backend\
     resource: '../Classes/ViewHelpers/Backend/*'
     public: true
     autowire: true
+    shared: false
 
   ApacheSolrForTypo3\Solr\Domain\Index\Queue\UpdateHandler\DataUpdateHandler:
     public: true
+    shared: true
     arguments:
       $recordService: '@ApacheSolrForTypo3\Solr\Domain\Index\Queue\RecordMonitor\Helper\ConfigurationAwareRecordService'
       $frontendEnvironment: '@ApacheSolrForTypo3\Solr\FrontendEnvironment'
@@ -79,6 +86,7 @@ services:
       $dataHandler: '@TYPO3\CMS\Core\DataHandling\DataHandler'
   ApacheSolrForTypo3\Solr\Domain\Index\Queue\UpdateHandler\GarbageHandler:
     public: true
+    shared: true
     arguments:
       $recordService: '@ApacheSolrForTypo3\Solr\Domain\Index\Queue\RecordMonitor\Helper\ConfigurationAwareRecordService'
       $frontendEnvironment: '@ApacheSolrForTypo3\Solr\FrontendEnvironment'
@@ -88,27 +96,33 @@ services:
   ApacheSolrForTypo3\Solr\Domain\Site\SiteHashService:
     public: true
     autowire: true
+    shared: true
 
   ApacheSolrForTypo3\Solr\IndexQueue\PageIndexerRequestHandler:
     public: true
     autowire: true
+    shared: true
 
   ApacheSolrForTypo3\Solr\EventListener\EnhancedRouting\CachedUrlModifier:
+    shared: true
     tags:
       - name: event.listener
         identifier: 'solr.routing.cachedurl-modifier'
         event: ApacheSolrForTypo3\Solr\Event\Routing\BeforeVariableInCachedUrlAreReplacedEvent
   ApacheSolrForTypo3\Solr\EventListener\EnhancedRouting\CachedPathVariableModifier:
+    shared: true
     tags:
       - name: event.listener
         identifier: 'solr.routing.cachedurl-modifier'
         event: ApacheSolrForTypo3\Solr\Event\Routing\BeforeCachedVariablesAreProcessedEvent
   ApacheSolrForTypo3\Solr\EventListener\EnhancedRouting\PostEnhancedUriProcessor:
+    shared: true
     tags:
       - name: event.listener
         identifier: 'solr.routing.postenhanceduriprocessor-modifier'
         event: ApacheSolrForTypo3\Solr\Event\Routing\AfterUriIsProcessedEvent
   ApacheSolrForTypo3\Solr\Domain\Index\Queue\UpdateHandler\EventListener\NoProcessingEventListener:
+    shared: true
     arguments:
       $extensionConfiguration: '@ApacheSolrForTypo3\Solr\System\Configuration\ExtensionConfiguration'
       $eventDispatcher: '@Psr\EventDispatcher\EventDispatcherInterface'
@@ -142,6 +156,7 @@ services:
         before: 'solr.index.updatehandler.immediateprocessingeventlistener,solr.index.updatehandler.delayedprocessingeventlistener'
         event: ApacheSolrForTypo3\Solr\Domain\Index\Queue\UpdateHandler\Events\RecordGarbageCheckEvent
   ApacheSolrForTypo3\Solr\Domain\Index\Queue\UpdateHandler\EventListener\ImmediateProcessingEventListener:
+    shared: true
     arguments:
       $extensionConfiguration: '@ApacheSolrForTypo3\Solr\System\Configuration\ExtensionConfiguration'
       $eventDispatcher: '@Psr\EventDispatcher\EventDispatcherInterface'
@@ -175,6 +190,7 @@ services:
         before: 'solr.index.updatehandler.delayedprocessingeventlistener'
         event: ApacheSolrForTypo3\Solr\Domain\Index\Queue\UpdateHandler\Events\RecordGarbageCheckEvent
   ApacheSolrForTypo3\Solr\Domain\Index\Queue\UpdateHandler\EventListener\DelayedProcessingEventListener:
+    shared: true
     arguments:
       $extensionConfiguration: '@ApacheSolrForTypo3\Solr\System\Configuration\ExtensionConfiguration'
       $eventDispatcher: '@Psr\EventDispatcher\EventDispatcherInterface'
@@ -204,61 +220,76 @@ services:
   # Register search components
   ApacheSolrForTypo3\Solr\Search\AccessComponent:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.search-component.access'
   ApacheSolrForTypo3\Solr\Search\AnalysisComponent:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.search-component.analysis'
   ApacheSolrForTypo3\Solr\Search\DebugComponent:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.search-component.debug'
   ApacheSolrForTypo3\Solr\Search\ElevationComponent:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.search-component.elevation'
   ApacheSolrForTypo3\Solr\Search\GroupingComponent:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.search-component.grouping'
   ApacheSolrForTypo3\Solr\Search\FacetingComponent:
     autowire: true
+    # Uses FacetRegistry, which is singleton. @todo: See classes doc-comment
+    shared: true
     tags:
       - name: event.listener
         identifier: 'solr.search-component.faceting'
   ApacheSolrForTypo3\Solr\Search\HighlightingComponent:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.search-component.highlighting'
   ApacheSolrForTypo3\Solr\Search\LastSearchesComponent:
     autowire: true
+    # @todo: See classes doc-comment
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.search-component.last-searches'
   ApacheSolrForTypo3\Solr\Search\RelevanceComponent:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.search-component.relevance'
   ApacheSolrForTypo3\Solr\Search\SortingComponent:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.search-component.sorting'
   ApacheSolrForTypo3\Solr\Search\SpellcheckingComponent:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.search-component.spellchecking'
   ApacheSolrForTypo3\Solr\Search\StatisticsComponent:
     autowire: true
+    # @todo: See classes doc-comment
+    shared: true
     tags:
       - name: event.listener
         identifier: 'solr.search-component.statistics'
@@ -269,38 +300,46 @@ services:
   ### Indexing
   ApacheSolrForTypo3\Solr\EventListener\PageIndexer\FrontendGroupsModifier:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.index.PageIndexer.FrontendUserAuthenticator'
 
   ApacheSolrForTypo3\Solr\IndexQueue\FrontendHelper\PageIndexer:
     autowire: true
+    shared: true
     tags:
       - name: event.listener
         identifier: 'solr.index.FrontendHelper.PageIndexer.indexPageContentAfterCacheableContentIsGenerated'
   ApacheSolrForTypo3\Solr\Task\IndexQueueWorkerTaskAdditionalFieldProvider:
     public: true
+    shared: true
     arguments:
       $siteRepository: '@ApacheSolrForTypo3\Solr\Domain\Site\SiteRepository'
 
   ApacheSolrForTypo3\Solr\EventListener\PageIndexer\AdditionalFieldsForPageIndexing:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.index.AdditionalFieldsForPageIndexing'
 
   ApacheSolrForTypo3\Solr\IndexQueue\FrontendHelper\PageFieldMappingIndexer:
     autowire: true
+    shared: false
     tags:
       - name: event.listener
         identifier: 'solr.index.PageFieldMappingIndexer'
 
   ApacheSolrForTypo3\Solr\IndexQueue\FrontendHelper\UserGroupDetector:
     autowire: true
+    # Only once usable in same request. No usage in other contexts.
+    shared: true
     autoconfigure: true
 
   ApacheSolrForTypo3\Solr\EventListener\Extbase\PersistenceEventListener:
     autowire: true
+    shared: true
     tags:
       - name: event.listener
         identifier: 'solr.index.ExtbaseEntityPersisted'
@@ -311,25 +350,28 @@ services:
 
   ###  EXT:solr content objects
   ApacheSolrForTypo3\Solr\ContentObject\Classification:
+    shared: false
     tags:
       - name: frontend.contentobject
         identifier: 'SOLR_CLASSIFICATION'
   ApacheSolrForTypo3\Solr\ContentObject\Content:
+    shared: false
     tags:
       - name: frontend.contentobject
         identifier: 'SOLR_CONTENT'
   ApacheSolrForTypo3\Solr\ContentObject\Multivalue:
+    shared: false
     tags:
       - name: frontend.contentobject
         identifier: 'SOLR_MULTIVALUE'
   ApacheSolrForTypo3\Solr\ContentObject\Relation:
+    shared: false
     arguments:
       $tcaService: '@ApacheSolrForTypo3\Solr\System\TCA\TCAService'
     tags:
       - name: frontend.contentobject
         identifier: 'SOLR_RELATION'
 
-
   # Reports: Status
   ApacheSolrForTypo3\Solr\Report\:
     resource: '../Classes/Report/*'